[Site Isolation] Clear CORS preflight cache between tests#63637
Merged
webkit-commit-queue merged 1 commit intoApr 27, 2026
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 54b0ae6) Details |
annevk
approved these changes
Apr 26, 2026
Contributor
annevk
left a comment
There was a problem hiding this comment.
This looks okay, modulo that I'm not 100% sure on the rules for API additions.
Collaborator
macOS Safer C++ Build #97414 (54b0ae6)❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming. |
Collaborator
iOS Safer C++ Build #15892 (54b0ae6)❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming. |
54b0ae6 to
4aee8a7
Compare
Collaborator
|
EWS run on current version of this PR (hash 4aee8a7) Details |
https://bugs.webkit.org/show_bug.cgi?id=313356 Reviewed by Anne van Kesteren. Three tests were failing under site isolation because WebKitTestRunner does not clear the CORS preflight cache in the network process between each test, meaning that CORS preflight from one test bleeds into another. Added a new mechanism to clear CORS preflight cache for testing purposes and calling it in TestController::resetStateToConsistentValues. Co-authored with Claude. Tests: http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header.html http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method.html http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html * LayoutTests/platform/ios-site-isolation/TestExpectations: * LayoutTests/platform/mac-site-isolation/TestExpectations: * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::clearCrossOriginPreflightResultCacheForTesting): * Source/WebKit/NetworkProcess/NetworkProcess.h: * Source/WebKit/NetworkProcess/NetworkProcess.messages.in: * Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp: (WKWebsiteDataStoreClearCrossOriginPreflightResultCacheForTesting): * Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h: * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::clearCrossOriginPreflightResultCacheForTesting): * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h: * Tools/WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): Canonical link: https://commits.webkit.org/312058@main
4aee8a7 to
c5b4561
Compare
Collaborator
|
Committed 312058@main (c5b4561): https://commits.webkit.org/312058@main Reviewed commits have been landed. Closing PR #63637 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c5b4561
4aee8a7