[TestWebKitAPI] Use framework-style include for WebCoreTestSupport.h#63652
Merged
webkit-commit-queue merged 1 commit intoApr 27, 2026
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 3374f9b) Details |
3374f9b to
b309164
Compare
Collaborator
|
EWS run on previous version of this PR (hash b309164) Details |
b309164 to
6cbfa64
Compare
Collaborator
|
EWS run on previous version of this PR (hash 6cbfa64) Details
|
6cbfa64 to
33638af
Compare
Collaborator
|
EWS run on current version of this PR (hash 33638af) Details |
rr-codes
approved these changes
Apr 27, 2026
<https://bugs.webkit.org/show_bug.cgi?id=313373> <rdar://175638226> Reviewed by Richard Robinson. Change `#import "WebCoreTestSupport.h"` to `#import <WebCoreTestSupport/WebCoreTestSupport.h>` in all TestWebKitAPI source files. This is possible since WebCoreTest headers were changed to install to `$(WK_LIBRARY_HEADERS_FOLDER_PATH)/WebCoreTestSupport/` for all build configurations, not just Production. * Configurations/WebKitProjectPaths.xcconfig: (WEBCORE_TEST_SUPPORT_DIR_Engineering): - Update to use `$(WK_LIBRARY_HEADERS_FOLDER_PATH)` to match the new install path for WebCoreTestSupport headers in engineering builds. * Source/WebCore/Configurations/WebCoreTestSupport.xcconfig: (PRIVATE_HEADERS_FOLDER_PATH): - Change WebCoreTest headers to install to `$(WK_LIBRARY_HEADERS_FOLDER_PATH)/WebCoreTestSupport/` for all build configurations. * Tools/TestWebKitAPI/Configurations/Base.xcconfig: (HEADER_SEARCH_PATHS): - Remove now unused `$(BUILT_PRODUCTS_DIR)/WebCoreTestSupport`. * Tools/TestWebKitAPI/InjectedBundle/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: * Tools/TestWebKitAPI/Tests/InjectInternals_Bundle.cpp: * Tools/TestWebKitAPI/Tests/WebCore/cocoa/MediaPlayerPrivateAVFoundationObjCTests.mm: * Tools/TestWebKitAPI/Tests/WebCore/cocoa/XMLParsing.mm: * Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ClickAutoFillButton.mm: * Tools/TestWebKitAPI/Tests/WebKit/WKWebView/DisableSpellcheckPlugIn.mm: * Tools/TestWebKitAPI/Tests/WebKit/WKWebView/InjectedBundleHitTestPlugIn.mm: * Tools/TestWebKitAPI/Tests/WebKit/WKWebView/PreferredAudioBufferSize.mm: * Tools/TestWebKitAPI/Tests/WebKit/WKWebView/TLSDeprecation.mm: * Tools/TestWebKitAPI/Tests/WebKit/WKWebView/mac/MediaPlaybackSleepAssertion.mm: - Switch to `#import <WebCoreTestSupport/WebCoreTestSupport.h>`. Canonical link: https://commits.webkit.org/312094@main
33638af to
3b8f247
Compare
Collaborator
|
Committed 312094@main (3b8f247): https://commits.webkit.org/312094@main Reviewed commits have been landed. Closing PR #63652 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 vision-apple
3b8f247
33638af