REGRESSION:(311911@main) [macOS]fonts/font-cache-memory-pressure-crash.html is a flaky text failure.#63755
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 3598bd4) Details |
cdumez
added
the
New Bugs
| Test passes if it doesn't crash. | ||
|
|
||
|
|
||
| ｕｎｄｅｆｉｎｅｄ |
Contributor
There was a problem hiding this comment.
Where is this "undefined" coming from? I see one option element, but unsure what's "undefined" there. And I don't see any such output when opening the test directly in Chrome.
Contributor
Author
There was a problem hiding this comment.
I didn't check (the test is a huge fuzzer generated one), "undefined" was already there. The is the existing LayoutTests/fonts/font-cache-memory-pressure-crash-expected.txt:
Test passes if it doesn't crash.
ｕｎｄｅｆｉｎｅｄ
The only thing my patch did in 311911@main was add 2 extra blank lines by changing a css stylesheet.
That said, it looks like it is failing on EWS so maybe the 2 new blank lines are only on a very specific config :( I'll look.
Contributor
There was a problem hiding this comment.
Ah right, rebaselining a flaky test wouldn't work :)
Contributor
Author
There was a problem hiding this comment.
Right, the radar had said consistent failure but looking at the bots, it was in fact flaky.
webkit-ews-buildbot
added
the
merging-blocked
cdumez
changed the title
cdumez
force-pushed
the
313282_test_rebaseline
branch
from
3598bd4 to
a6432ae
Compare
Collaborator
|
EWS run on previous version of this PR (hash a6432ae) Details
|
cdumez
force-pushed
the
313282_test_rebaseline
branch
from
a6432ae to
040546f
Compare
Collaborator
|
EWS run on current version of this PR (hash 040546f) Details
|
rniwa
approved these changes
Apr 28, 2026
cdumez
added
safe-merge-queue
…h.html is a flaky text failure. https://bugs.webkit.org/show_bug.cgi?id=313282 rdar://175554270 Reviewed by Ryosuke Niwa. 311911@main updated the user agent style sheet to mark `option` and `optgroup` as `display: block`. This caused this fuzzer-generated test to become flaky with 2 extra blank lines, presumably due to option or optgroup elements in the DOM tree that now are displayed as block instead of inline. To address the flakiness, restore the old behavior for this test by marking `option` and `optgroup` as `display: inline` in the <style> at the beginning of the test. * LayoutTests/fonts/font-cache-memory-pressure-crash.html: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/312192@main
webkit-commit-queue
force-pushed
the
313282_test_rebaseline
branch
from
040546f to
404e188
Compare
Collaborator
|
Committed 312192@main (404e188): https://commits.webkit.org/312192@main Reviewed commits have been landed. Closing PR #63755 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
404e188
040546f
🛠 win🧪 win-tests🧪 ios-wk2-wpt🧪 api-mac-debug🧪 api-ios