[:has()] Fix failures in css/selectors/invalidation/has-invalidation-first-in-sibling-chain.html WPT#63782
Merged
Conversation
Collaborator
|
EWS run on current version of this PR (hash f1e38bc) Details
|
alanbaradlay
approved these changes
Apr 28, 2026
…first-in-sibling-chain.html WPT https://bugs.webkit.org/show_bug.cgi?id=313527 rdar://175738008 Reviewed by Alan Baradlay. Sibling relation bits for :has() can't be reset normally before resolving a subtree because they can get set for any element at any point of style resolution. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-invalidation-first-in-sibling-chain-expected.txt: * Source/WebCore/dom/Element.cpp: (WebCore::Element::resetStyleRelations): (WebCore::Element::resetAllDescendantStyleRelations): (WebCore::Element::resetHasSiblingFlags): * Source/WebCore/dom/Element.h: * Source/WebCore/style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resetDescendantStyleRelations): Fix by only reseting in case of a full style rebuild from root. * Source/WebCore/style/StyleTreeResolver.h: Canonical link: https://commits.webkit.org/312221@main
f1e38bc to
45d24e3
Compare
Collaborator
|
Committed 312221@main (45d24e3): https://commits.webkit.org/312221@main Reviewed commits have been landed. Closing PR #63782 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
45d24e3
f1e38bc