Improve libatomic test in WebKitCompilerFlags.cmake#63783
Merged
webkit-commit-queue merged 1 commit intoApr 28, 2026
Merged
Conversation
Collaborator
|
EWS run on current version of this PR (hash ff68c99) Details |
Collaborator
|
@bertogg does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json. If you do have committer permissions, please ensure that your GitHub username is added to contributors.json. Rejecting ff68c99f4a63dbedded10914c879bbb77a7df718 from merge queue. |
aperezdc
approved these changes
Apr 28, 2026
https://bugs.webkit.org/show_bug.cgi?id=313534 Reviewed by Adrian Perez de Castro and Michael Catanzaro. Fail immediately if the atomic source test cannot be built, even when using libatomic. * Source/cmake/WebKitCompilerFlags.cmake: Canonical link: https://commits.webkit.org/312202@main
ff68c99 to
36c3761
Compare
Collaborator
|
Committed 312202@main (36c3761): https://commits.webkit.org/312202@main Reviewed commits have been landed. Closing PR #63783 and removing active labels. |
Contributor
|
Backported into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧪 services
36c3761
ff68c99
🛠 playstation🛠 🧪 unsafe-merge