Skip to content

Improve libatomic test in WebKitCompilerFlags.cmake#63783

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
bertogg:eng/Improve-libatomic-test-in-WebKitCompilerFlags-cmake
Apr 28, 2026
Merged

Improve libatomic test in WebKitCompilerFlags.cmake#63783
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
bertogg:eng/Improve-libatomic-test-in-WebKitCompilerFlags-cmake

Conversation

@bertogg
Copy link
Copy Markdown
Contributor

@bertogg bertogg commented Apr 28, 2026

@bertogg bertogg requested a review from mcatanzaro as a code owner April 28, 2026 10:07
@bertogg bertogg self-assigned this Apr 28, 2026
@bertogg bertogg added CMake Bugzilla component for CMake build system changes unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Apr 28, 2026
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

@bertogg does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json.

If you do have committer permissions, please ensure that your GitHub username is added to contributors.json.

Rejecting ff68c99f4a63dbedded10914c879bbb77a7df718 from merge queue.

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Apr 28, 2026
@aperezdc aperezdc added the GLib Suggested Backport - 2.52 Suggest this merge request be backported to the webkitglib/2.52 stable branch label Apr 28, 2026
@aperezdc aperezdc added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Apr 28, 2026
@webkit-ews-buildbot webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Apr 28, 2026
Copy link
Copy Markdown
Contributor

@mcatanzaro mcatanzaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mcatanzaro mcatanzaro added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Apr 28, 2026
https://bugs.webkit.org/show_bug.cgi?id=313534

Reviewed by Adrian Perez de Castro and Michael Catanzaro.

Fail immediately if the atomic source test cannot be built, even when
using libatomic.

* Source/cmake/WebKitCompilerFlags.cmake:

Canonical link: https://commits.webkit.org/312202@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Improve-libatomic-test-in-WebKitCompilerFlags-cmake branch from ff68c99 to 36c3761 Compare April 28, 2026 15:14
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 312202@main (36c3761): https://commits.webkit.org/312202@main

Reviewed commits have been landed. Closing PR #63783 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 36c3761 into WebKit:main Apr 28, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 28, 2026
@bertogg bertogg deleted the eng/Improve-libatomic-test-in-WebKitCompilerFlags-cmake branch April 28, 2026 15:18
@aperezdc
Copy link
Copy Markdown
Contributor

Backported into webkitglib/2.52 as commit 51fd523

@aperezdc aperezdc removed the GLib Suggested Backport - 2.52 Suggest this merge request be backported to the webkitglib/2.52 stable branch label Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake Bugzilla component for CMake build system changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants