Skip to content

Introduce JSC_useFuzzerMode, and use it to disable certain $vm features.#63837

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
MenloDorian:eng/Introduce-JSC_useFuzzerMode-and-use-it-to-disable-certain-vm-features
Apr 29, 2026
Merged

Introduce JSC_useFuzzerMode, and use it to disable certain $vm features.#63837
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
MenloDorian:eng/Introduce-JSC_useFuzzerMode-and-use-it-to-disable-certain-vm-features

Conversation

@MenloDorian
Copy link
Copy Markdown

@MenloDorian MenloDorian commented Apr 28, 2026

@MenloDorian MenloDorian requested a review from a team as a code owner April 28, 2026 22:20
@MenloDorian MenloDorian self-assigned this Apr 28, 2026
@MenloDorian MenloDorian added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Apr 28, 2026
@MenloDorian MenloDorian force-pushed the eng/Introduce-JSC_useFuzzerMode-and-use-it-to-disable-certain-vm-features branch from 053b84e to 75de565 Compare April 29, 2026 14:52
Copy link
Copy Markdown
Contributor

@kmiller68 kmiller68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nit

addFunction(vm, "crash"_s, functionCrash, 0);
addFunction(vm, "breakpoint"_s, functionBreakpoint, 0);
addFunction(vm, "exit"_s, functionExit, 0);
bool alwaysAllow = true;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: constexpr

@MenloDorian MenloDorian added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 29, 2026
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Introduce-JSC_useFuzzerMode-and-use-it-to-disable-certain-vm-features branch from 75de565 to 60e7dba Compare April 29, 2026 17:23
https://bugs.webkit.org/show_bug.cgi?id=313576
rdar://175791475

Reviewed by Keith Miller.

$vm features are for development and testing use only, and is not enabled in deployment.  It does
not make sense to fuzz the majority of $vm features.

Covered by existing JSC tests since existing JSC tests use all the $vm features.

* Source/JavaScriptCore/runtime/OptionsList.h:
* Source/JavaScriptCore/tools/JSDollarVM.cpp:
(JSC::JSDollarVM::finishCreation):

Canonical link: https://commits.webkit.org/312299@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Introduce-JSC_useFuzzerMode-and-use-it-to-disable-certain-vm-features branch from 60e7dba to 865e2fa Compare April 29, 2026 17:24
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 312299@main (865e2fa): https://commits.webkit.org/312299@main

Reviewed commits have been landed. Closing PR #63837 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 865e2fa into WebKit:main Apr 29, 2026
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 29, 2026
@MenloDorian MenloDorian deleted the eng/Introduce-JSC_useFuzzerMode-and-use-it-to-disable-certain-vm-features branch April 29, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants