[LBSE] Prepare computeVisibleRectsInSVGContainer for non-layered SVG elements#63881
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 29f651f) Details |
🛠 win
nikolaszimmermann
approved these changes
Apr 29, 2026
Contributor
nikolaszimmermann
left a comment
nikolaszimmermann
left a comment
There was a problem hiding this comment.
LGTM with one nit.
| transform = *layer()->transform(); | ||
|
|
||
| if (!transform.isIdentity()) | ||
| adjustedRects.transform(transform); |
Contributor
There was a problem hiding this comment.
Since we only need the TransformationMatrix for the adjustedRects mapping, I would avoid creating a local variable copying the whole matrix, but just execute the mapping for both cases.
Contributor
Author
There was a problem hiding this comment.
Got it, I removed the local var.
rwlbuis
force-pushed
the
eng/LBSE-Prepare-computeVisibleRectsInSVGContainer-for-non-layered-SVG-elements
branch
from
29f651f to
4aaf2df
Compare
Collaborator
|
EWS run on current version of this PR (hash 4aaf2df) Details |
…elements https://bugs.webkit.org/show_bug.cgi?id=313637 Reviewed by Nikolas Zimmermann. Prepare computeVisibleRectsInSVGContainer for non-layered SVG elements by relying for this new case on localTransform instead of the transform cached inside RenderLayer. * Source/WebCore/rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::computeVisibleRectsInSVGContainer const): Canonical link: https://commits.webkit.org/312347@main
webkit-commit-queue
force-pushed
the
eng/LBSE-Prepare-computeVisibleRectsInSVGContainer-for-non-layered-SVG-elements
branch
from
4aaf2df to
642e030
Compare
Collaborator
|
Committed 312347@main (642e030): https://commits.webkit.org/312347@main Reviewed commits have been landed. Closing PR #63881 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
rwlbuis
deleted the
eng/LBSE-Prepare-computeVisibleRectsInSVGContainer-for-non-layered-SVG-elements
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
642e030
4aaf2df
🛠 win🧪 wpe-wk2🧪 win-tests🧪 api-mac🧪 ios-wk2-wpt🧪 api-mac-debug🛠 gtk3-libwebrtc🧪 api-ios🛠 ios-safer-cpp🧪 gtk-wk2🧪 mac-AS-debug-wk2🧪 api-gtk🛠 vision-sim🛠 playstation🧪 vision-wk2🧪 mac-intel-wk2🛠 mac-safer-cpp🛠 tv-sim🛠 watch🛠 watch-sim