Stop persisting service workers from browser extensions to disk#63883
Merged
webkit-commit-queue merged 1 commit intoApr 29, 2026
Merged
Conversation
Collaborator
|
EWS run on current version of this PR (hash 4cea04e) Details
|
youennf
approved these changes
Apr 29, 2026
cdumez
added
the
safe-merge-queue
webkit-ews-buildbot
added
merge-queue
Collaborator
|
Safe-Merge-Queue: Build #91054. |
https://bugs.webkit.org/show_bug.cgi?id=313635 Reviewed by Youenn Fablet. Stop persisting service workers from browser extensions to disk. It is unnecessary and the data saved to disk would not be functional when loaded back from disk anyway. * Source/WebCore/workers/service/server/SWRegistrationDatabase.cpp: (WebCore::SWRegistrationDatabase::updateRegistrationsImpl): * Source/WebCore/workers/service/server/SWServer.cpp: (WebCore::SWServer::didFinishInstall): (WebCore::SWServer::storeRegistrationForWorkerIfNecessary): (WebCore::SWServer::storeRegistrationForWorker): Deleted. * Source/WebCore/workers/service/server/SWServer.h: * Source/WebCore/workers/service/server/SWServerRegistration.cpp: (WebCore::SWServerRegistration::enableNavigationPreload): (WebCore::SWServerRegistration::disableNavigationPreload): (WebCore::SWServerRegistration::setNavigationPreloadHeaderValue): * Source/WebCore/workers/service/server/SWServerWorker.cpp: (WebCore::SWServerWorker::shouldPersistToDisk const): * Source/WebCore/workers/service/server/SWServerWorker.h: * Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ServiceWorkerBasic.mm: ((ServiceWorker, ExtensionServiceWorkerNotPersistedToDisk)): Canonical link: https://commits.webkit.org/312316@main
webkit-commit-queue
force-pushed
the
313635_extensions_sw_non_persistent
branch
from
4cea04e to
eff9f92
Compare
Collaborator
|
Committed 312316@main (eff9f92): https://commits.webkit.org/312316@main Reviewed commits have been landed. Closing PR #63883 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
xeenon
reviewed
Apr 30, 2026
| RELEASE_LOG(ServiceWorker, "%p - CHRIS: SWServer::storeRegistrationForWorkerIfNecessary: service worker %" PRIu64, this, worker.identifier().toUInt64()); | ||
|
|
||
| if (!worker.shouldPersistToDisk()) { | ||
| RELEASE_LOG(ServiceWorker, "%p - CHRIS: SWServer::storeRegistrationForWorkerIfNecessary: Not saving service worker %" PRIu64 " to disk since it is backing a browser extension", this, worker.identifier().toUInt64()); |
xeenon
reviewed
Apr 30, 2026
| void SWServer::storeRegistrationForWorker(SWServerWorker& worker) | ||
| void SWServer::storeRegistrationForWorkerIfNecessary(SWServerWorker& worker) | ||
| { | ||
| RELEASE_LOG(ServiceWorker, "%p - CHRIS: SWServer::storeRegistrationForWorkerIfNecessary: service worker %" PRIu64, this, worker.identifier().toUInt64()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eff9f92
4cea04e
🧪 win-tests