Skip to content

[Site Isolation] Update expected output for plugins-types-allows-youtube-plugin-replacement.html#64074

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
roberto-apple:eng/Site-Isolation-Update-expected-output-for-plugins-types-allows-youtube-plugin-replacement-html
May 4, 2026
Merged

[Site Isolation] Update expected output for plugins-types-allows-youtube-plugin-replacement.html#64074
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
roberto-apple:eng/Site-Isolation-Update-expected-output-for-plugins-types-allows-youtube-plugin-replacement-html

Conversation

@roberto-apple
Copy link
Copy Markdown
Contributor

@roberto-apple roberto-apple commented May 1, 2026

b412368

[Site Isolation] Update expected output for plugins-types-allows-youtube-plugin-replacement.html
https://bugs.webkit.org/show_bug.cgi?id=313851
rdar://176052705

Reviewed by Megan Gardner and Ryosuke Niwa.

The number of deprecation console messages differ between non-SI and SI configurations because the
youtube.com iframe navigation is canceled at different loading stages, producing different numbers of
about:blank documents that inherit and re-parse the parent CSP where each re-parse fires the deprecation
warning again. The current expected output only matches the non-SI case.

Since the test only needs to verify the plugin replacement iframe is created, suppress the console
messages from the output so both configurations pass.

Also update TestController.cpp's SI external URL blocking path to check dumpJSConsoleLogInStdErr. Without it
the "Blocked access" message leaks into test output under SI even when console messages are suppressed,
because this path writes directly to the output rather than going through the console pipeline.

* LayoutTests/platform/ios-site-isolation/TestExpectations:
* LayoutTests/platform/mac-site-isolation/TestExpectations:
* LayoutTests/security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement-expected.txt:
* LayoutTests/security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html:
* Tools/WebKitTestRunner/TestController.cpp:

Canonical link: https://commits.webkit.org/312554@main

00b2343

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@roberto-apple roberto-apple self-assigned this May 1, 2026
@roberto-apple roberto-apple added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label May 1, 2026
@roberto-apple roberto-apple force-pushed the eng/Site-Isolation-Update-expected-output-for-plugins-types-allows-youtube-plugin-replacement-html branch from 22a7814 to 00b2343 Compare May 1, 2026 22:57
@roberto-apple roberto-apple marked this pull request as ready for review May 4, 2026 16:56
@roberto-apple roberto-apple requested a review from JonWBedard as a code owner May 4, 2026 16:56
@roberto-apple roberto-apple added the merge-queue Applied to send a pull request to merge-queue label May 4, 2026
…ube-plugin-replacement.html

https://bugs.webkit.org/show_bug.cgi?id=313851
rdar://176052705

Reviewed by Megan Gardner and Ryosuke Niwa.

The number of deprecation console messages differ between non-SI and SI configurations because the
youtube.com iframe navigation is canceled at different loading stages, producing different numbers of
about:blank documents that inherit and re-parse the parent CSP where each re-parse fires the deprecation
warning again. The current expected output only matches the non-SI case.

Since the test only needs to verify the plugin replacement iframe is created, suppress the console
messages from the output so both configurations pass.

Also update TestController.cpp's SI external URL blocking path to check dumpJSConsoleLogInStdErr. Without it
the "Blocked access" message leaks into test output under SI even when console messages are suppressed,
because this path writes directly to the output rather than going through the console pipeline.

* LayoutTests/platform/ios-site-isolation/TestExpectations:
* LayoutTests/platform/mac-site-isolation/TestExpectations:
* LayoutTests/security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement-expected.txt:
* LayoutTests/security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html:
* Tools/WebKitTestRunner/TestController.cpp:

Canonical link: https://commits.webkit.org/312554@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Site-Isolation-Update-expected-output-for-plugins-types-allows-youtube-plugin-replacement-html branch from 00b2343 to b412368 Compare May 4, 2026 21:31
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 312554@main (b412368): https://commits.webkit.org/312554@main

Reviewed commits have been landed. Closing PR #64074 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b412368 into WebKit:main May 4, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants