[Site Isolation] Update expected output for plugins-types-allows-youtube-plugin-replacement.html#64074
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 22a7814) Details |
22a7814 to
00b2343
Compare
Collaborator
|
EWS run on current version of this PR (hash 00b2343) Details |
megangardner
approved these changes
May 4, 2026
rniwa
approved these changes
May 4, 2026
…ube-plugin-replacement.html https://bugs.webkit.org/show_bug.cgi?id=313851 rdar://176052705 Reviewed by Megan Gardner and Ryosuke Niwa. The number of deprecation console messages differ between non-SI and SI configurations because the youtube.com iframe navigation is canceled at different loading stages, producing different numbers of about:blank documents that inherit and re-parse the parent CSP where each re-parse fires the deprecation warning again. The current expected output only matches the non-SI case. Since the test only needs to verify the plugin replacement iframe is created, suppress the console messages from the output so both configurations pass. Also update TestController.cpp's SI external URL blocking path to check dumpJSConsoleLogInStdErr. Without it the "Blocked access" message leaks into test output under SI even when console messages are suppressed, because this path writes directly to the output rather than going through the console pipeline. * LayoutTests/platform/ios-site-isolation/TestExpectations: * LayoutTests/platform/mac-site-isolation/TestExpectations: * LayoutTests/security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement-expected.txt: * LayoutTests/security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html: * Tools/WebKitTestRunner/TestController.cpp: Canonical link: https://commits.webkit.org/312554@main
00b2343 to
b412368
Compare
Collaborator
|
Committed 312554@main (b412368): https://commits.webkit.org/312554@main Reviewed commits have been landed. Closing PR #64074 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b412368
00b2343