Skip to content

[TestWebKitAPI] macCatalyst build is broken (TestWebKitAPI.swift:73:9: error: cannot find 'UINSApplicationInstantiate' in scope)#64087

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
aprotyas:eng/313873
May 6, 2026
Merged

Conversation

@aprotyas
Copy link
Copy Markdown
Member

@aprotyas aprotyas commented May 2, 2026 •
edited by webkit-early-warning-system
Loading

c05337b

[TestWebKitAPI] macCatalyst build is broken (TestWebKitAPI.swift:73:9: error: cannot find 'UINSApplicationInstantiate' in scope)
https://bugs.webkit.org/show_bug.cgi?id=313873
rdar://176071541

Reviewed by Richard Robinson.

TestWebKitAPI.swift was calling UINSApplicationInstantiate() under
`#if WTF_PLATFORM_MACCATALYST`, but never imported the module exposing
it. The module map maps Helpers/ios/UIKitMacHelperSPI.h to submodule
TestWebKitAPILibrary.Helpers.ios.UIKitMacHelperSPI. This patch adds a
conditional import to work around the build fail.

We also apply the Swift-Cxx interop settings to the base config under
TWKAPI, so that other test targets (like TestWTF and TestIPC) can pick
them up.

* Tools/TestWebKitAPI/Configurations/Base.xcconfig:
* Tools/TestWebKitAPI/Configurations/TestWTF.xcconfig:
* Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
* Tools/TestWebKitAPI/Runner/TestWebKitAPI.swift:

Canonical link: https://commits.webkit.org/312706@main

239d3f0

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@aprotyas aprotyas requested a review from rr-codes as a code owner May 2, 2026 03:57
@aprotyas aprotyas self-assigned this May 2, 2026
@aprotyas aprotyas added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label May 2, 2026
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented May 2, 2026 •
edited
Loading

EWS run on previous version of this PR (hash 3842786)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

rr-codes
rr-codes reviewed May 2, 2026
View reviewed changes
Comment thread Tools/TestWebKitAPI/Runner/TestWebKitAPI.swift Outdated
rr-codes
rr-codes reviewed May 2, 2026
View reviewed changes
Comment thread Tools/TestWebKitAPI/Runner/TestWebKitAPI.swift Outdated
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented May 3, 2026 •
edited
Loading

EWS run on previous version of this PR (hash 7e8b2a0)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ❌ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ❌ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ❌ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ❌ 🧪 mac-wk1 ✅ 🛠 gtk
❌ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 3, 2026
@aprotyas aprotyas removed the merging-blocked Applied to prevent a change from being merged label May 3, 2026
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented May 3, 2026 •
edited
Loading

EWS run on previous version of this PR (hash 4e2265e)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ❌ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ❌ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ❌ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ❌ 🧪 mac-wk1 ✅ 🛠 gtk
❌ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 3, 2026
@aprotyas aprotyas removed the merging-blocked Applied to prevent a change from being merged label May 5, 2026
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented May 5, 2026 •
edited
Loading

EWS run on previous version of this PR (hash 0a74fed)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
loading 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented May 6, 2026 •
edited
Loading

EWS run on current version of this PR (hash 239d3f0)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@aprotyas
Copy link
Copy Markdown
Member Author

aprotyas commented May 6, 2026

Thank you for the review!

@aprotyas aprotyas added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 6, 2026
@aprotyas
[TestWebKitAPI] macCatalyst build is broken (TestWebKitAPI.swift:73:9…
c05337b 
…: error: cannot find 'UINSApplicationInstantiate' in scope)

https://bugs.webkit.org/show_bug.cgi?id=313873
rdar://176071541

Reviewed by Richard Robinson.

TestWebKitAPI.swift was calling UINSApplicationInstantiate() under
`#if WTF_PLATFORM_MACCATALYST`, but never imported the module exposing
it. The module map maps Helpers/ios/UIKitMacHelperSPI.h to submodule
TestWebKitAPILibrary.Helpers.ios.UIKitMacHelperSPI. This patch adds a
conditional import to work around the build fail.

We also apply the Swift-Cxx interop settings to the base config under
TWKAPI, so that other test targets (like TestWTF and TestIPC) can pick
them up.

* Tools/TestWebKitAPI/Configurations/Base.xcconfig:
* Tools/TestWebKitAPI/Configurations/TestWTF.xcconfig:
* Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
* Tools/TestWebKitAPI/Runner/TestWebKitAPI.swift:

Canonical link: https://commits.webkit.org/312706@main
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

webkit-commit-queue commented May 6, 2026

Committed 312706@main (c05337b): https://commits.webkit.org/312706@main

Reviewed commits have been landed. Closing PR #64087 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c05337b into WebKit:main May 6, 2026
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 6, 2026
@aprotyas aprotyas deleted the eng/313873 branch May 6, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rr-codes rr-codes rr-codes approved these changes

@emw-apple emw-apple Awaiting requested review from emw-apple emw-apple is a code owner

Assignees

@aprotyas aprotyas

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aprotyas @webkit-early-warning-system @webkit-commit-queue @rr-codes @webkit-ews-buildbot