[GStreamer] Assorted minor clean-ups#64093
Merged
Merged
Conversation
philn
added
the
Platform
Collaborator
|
EWS run on previous version of this PR (hash b2680da) Details |
calvaris
approved these changes
May 5, 2026
| @@ -140,7 +140,11 @@ static void webkitMediaThunderParserConstructed(GObject* object) | |||
| G_OBJECT_CLASS(webkit_media_thunder_parser_parent_class)->constructed(object); | |||
|
|
|||
| auto self = WEBKIT_MEDIA_THUNDER_PARSER(object); | |||
| self->priv->parser = makeGStreamerElement("parsebin"_s, "inner-parser"_s); | |||
|
|
|||
| static uint32_t nParsers = 0; | |||
Contributor
There was a problem hiding this comment.
I wonder if we should make this atomic
Collaborator
|
EWS run on current version of this PR (hash 2eca970) Details |
https://bugs.webkit.org/show_bug.cgi?id=313885 Reviewed by Xabier Rodriguez-Calvar. * Source/WebCore/platform/graphics/gstreamer/eme/CDMProxyThunder.cpp: (WebCore::CDMProxyThunder::decrypt): Remove un-needed GST_TRACE call, there is one already in the decryptor. * Source/WebCore/platform/graphics/gstreamer/eme/WebKitThunderParser.cpp: (webkitMediaThunderParserConstructed): Give meaningful names to the internal parsebin element, to ease debugging. Also sort element factories by rank, same as for decryptors. * Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp: (WebCore::AppendPipeline::appsrcEndOfAppendCheckerProbe): Give meaningful name to end-of-append dot files. * Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp: Remove un-necessary header includes. * Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp: Ditto and also remove un-used GRefPtr traits for WebKitMediaSrc. * Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.h: Improve WebKit coding style compliance. Canonical link: https://commits.webkit.org/312602@main
webkit-commit-queue
force-pushed
the
eng/313885
branch
from
2eca970 to
450d297
Compare
Collaborator
|
Committed 312602@main (450d297): https://commits.webkit.org/312602@main Reviewed commits have been landed. Closing PR #64093 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
450d297
2eca970
🛠 win🧪 wpe-wk2🧪 win-tests🧪 api-mac🧪 ios-wk2-wpt🧪 api-mac-debug🧪 api-ios🛠 ios-safer-cpp🧪 gtk-wk2🧪 mac-AS-debug-wk2🧪 mac-intel-wk2🛠 mac-safer-cpp