ASSERTION FAILED: m_wrapper from WebCore::JSEventListener::ensureJSFunction in Navigation::innerDispatchNavigateEvent#64145
Closed
cdumez wants to merge 1 commit into
Conversation
Collaborator
|
EWS run on previous version of this PR (hash db10393) Details |
cdumez
added
the
WebCore Misc.
cdumez
force-pushed
the
310813_navigation_api_no_dispatch_after_context_gone
branch
from
db10393 to
597dfc3
Compare
Collaborator
|
EWS run on previous version of this PR (hash 597dfc3) Details
|
basuke
reviewed
May 5, 2026
| @@ -1310,7 +1310,8 @@ Navigation::DispatchResult Navigation::innerDispatchNavigateEvent(NavigationNavi | |||
| m_focusChangedDuringOngoingNavigation = FocusDidChange::No; | |||
| m_suppressNormalScrollRestorationDuringOngoingNavigation = false; | |||
|
|
|||
| dispatchEvent(event); | |||
| if (document && !document->activeDOMObjectsAreStopped()) | |||
| dispatchEvent(event); | |||
Contributor
There was a problem hiding this comment.
No need to abort event and return Aborted as other failure cases?
…nction in Navigation::innerDispatchNavigateEvent https://bugs.webkit.org/show_bug.cgi?id=310813 rdar://162816815 Reviewed by NOBODY (OOPS!). Do not try to dispatch the navigate event if the script execution context is gone or stopped, to avoid tripping assertions due to the JS wrapper being gone. Test: navigation-api/navigation-navigate-event-after-gc.html * LayoutTests/navigation-api/navigation-navigate-event-after-gc-expected.txt: Added. * LayoutTests/navigation-api/navigation-navigate-event-after-gc.html: Added. * LayoutTests/navigation-api/resources/navigate-with-intercept.html: Added. * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::hasEntriesAndEventsDisabled const):
cdumez
force-pushed
the
310813_navigation_api_no_dispatch_after_context_gone
branch
from
597dfc3 to
12876cf
Compare
Collaborator
|
EWS run on current version of this PR (hash 12876cf) Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
12876cf
12876cf
🛠 ios🛠 wpe🛠 win🛠 mac-AS-debug🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 api-mac-debug🛠 gtk3-libwebrtc🧪 api-ios🧪 mac-wk1🛠 gtk🛠 ios-safer-cpp🧪 mac-wk2🧪 gtk-wk2🛠 vision🧪 mac-AS-debug-wk2🧪 api-gtk🛠 vision-sim🧪 mac-wk2-stress🛠 playstation🧪 vision-wk2🧪 mac-intel-wk2🛠 tv🛠 mac-safer-cpp🛠 tv-sim🛠 watch🛠 watch-sim