[CMake] Resolve compiler path at configure time#64229
Merged
webkit-commit-queue merged 1 commit intoMay 5, 2026
Merged
Conversation
geoffreygaren
added
the
New Bugs
Collaborator
|
EWS run on current version of this PR (hash 18ac410) Details
|
Contributor
Author
|
FWIW, Ninja timing data confirms ~12 ms / .cpp file saved. |
geoffreygaren
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=314039 rdar://176224089 Reviewed by David Kilzer. This is a minor speedup (visible in the profile, but measured end-to-end as 0.4%, which is in the noise.) It also keeps the toolchain and SDK in sync (since we already resolve the SDK path and version at configure time). * Source/cmake/OptionsMac.cmake: Canonical link: https://commits.webkit.org/312581@main
webkit-commit-queue
force-pushed
the
eng/CMake-Resolve-compiler-path-at-configure-time
branch
from
18ac410 to
bb54639
Compare
Collaborator
|
Committed 312581@main (bb54639): https://commits.webkit.org/312581@main Reviewed commits have been landed. Closing PR #64229 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bb54639
18ac410
🛠 win🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 ios-wk2-wpt🧪 api-mac-debug🛠 🧪 jsc🧪 api-ios🛠 🧪 jsc-debug-arm64🧪 gtk-wk2🧪 mac-AS-debug-wk2🛠 playstation🧪 mac-intel-wk2