Skip to content

Multiple files include CookieStorage.h but don't use it#64348

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
RupinMittal:eng/RemoveUnneededIncludesOfCookieStorage
May 6, 2026
Merged

Multiple files include CookieStorage.h but don't use it#64348
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
RupinMittal:eng/RemoveUnneededIncludesOfCookieStorage

Conversation

@RupinMittal
Copy link
Copy Markdown
Contributor

@RupinMittal RupinMittal commented May 6, 2026

@RupinMittal RupinMittal self-assigned this May 6, 2026
@RupinMittal RupinMittal added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label May 6, 2026
@RupinMittal RupinMittal marked this pull request as ready for review May 6, 2026 16:42
@RupinMittal RupinMittal requested a review from cdumez as a code owner May 6, 2026 16:42
@RupinMittal RupinMittal requested a review from pvollan May 6, 2026 16:43
@RupinMittal RupinMittal added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 6, 2026
https://bugs.webkit.org/show_bug.cgi?id=314176
rdar://176337336

Reviewed by Per Arne Vollan.

We can remove these includes because they're not used.

* Source/WebCore/page/SettingsBase.cpp:
* Source/WebCore/platform/network/cocoa/ResourceHandleCocoa.mm:
* Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp:

Canonical link: https://commits.webkit.org/312714@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/RemoveUnneededIncludesOfCookieStorage branch from 06dc553 to 4a0d77c Compare May 6, 2026 17:36
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 312714@main (4a0d77c): https://commits.webkit.org/312714@main

Reviewed commits have been landed. Closing PR #64348 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 4a0d77c into WebKit:main May 6, 2026
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants