[MathML Core] Update prefixs +/−/±/∓, prefix ∇ and infix ⋉ spacing in Operator Dictionary and fix dynamic case#64613
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom May 11, 2026
Conversation
Collaborator
|
EWS run on previous version of this PR (hash a250825) Details |
Collaborator
iOS Safer C++ Build #20016 (a250825)❌ Found 1 failing file with 4 issues. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming. |
Collaborator
macOS Safer C++ Build #101671 (a250825)❌ Found 1 failing file with 4 issues. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming. |
a250825 to
c562bf3
Compare
Collaborator
|
EWS run on previous version of this PR (hash c562bf3) Details |
fred-wang
approved these changes
May 11, 2026
c562bf3 to
64f43aa
Compare
Collaborator
|
EWS run on previous version of this PR (hash 64f43aa) Details
|
64f43aa to
baddbf3
Compare
Collaborator
|
EWS run on current version of this PR (hash baddbf3) Details |
… Operator Dictionary and fix dynamic case https://bugs.webkit.org/show_bug.cgi?id=314477 rdar://176652211 Reviewed by Frédéric Wang Nélar. This patch syncs outdated below entries with the MathML Core operator dictionary [1]: U+002B + Prefix: (0,1) -> (0,0) U+00B1 ± Prefix: (0,1) -> (0,0) U+2212 − Prefix: (0,1) -> (0,0) U+2213 ∓ Prefix: (0,1) -> (0,0) U+2207 ∇ Prefix: (2,1) -> (0,0) U+22C9 ⋉ Infix: (4,4) -> (3,3) MathMLRowElement::childrenChanged already invalidates each child operator's cached dictionary property via setOperatorFormDirty(), but the old implementation only cleared the cache; the operator's renderer was never marked dirty, so the next layout saw "no layout needed" and painted the stale pre-mutation spacing. Move setOperatorFormDirty() out-of-line and mirror the attributeChanged(form) path: reset the operator-flag dirty bits and call updateFromElement() + setNeedsLayoutAndPreferredWidthsUpdate() on the renderer so the sibling-triggered form switch actually takes effect. [1] https://www.w3.org/TR/mathml-core/#operator-dictionary-human * LayoutTests/TestExpectations: Progressions * Source/WebCore/mathml/MathMLOperatorDictionary.cpp: * Source/WebCore/mathml/MathMLOperatorElement.cpp: (WebCore::MathMLOperatorElement::setOperatorFormDirty): * Source/WebCore/mathml/MathMLOperatorElement.h: > Duplicate of `mo-form.html` from WPT: * LayoutTests/mathml/presentation/mo-form-expected.html: Removed. * LayoutTests/mathml/presentation/mo-form.html: Removed. > Updated local test to new behavior (WPT coverage not for these scenarios): * LayoutTests/mathml/presentation/dir-mo-expected.html: * LayoutTests/mathml/presentation/mo-lspace-rspace-expected.html: Canonical link: https://commits.webkit.org/312999@main
baddbf3 to
caf4d10
Compare
Collaborator
|
Committed 312999@main (caf4d10): https://commits.webkit.org/312999@main Reviewed commits have been landed. Closing PR #64613 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
caf4d10
baddbf3
🧪 win-tests🧪 api-mac🧪 ios-wk2-wpt🧪 api-mac-debug🧪 gtk-wk2🧪 mac-AS-debug-wk2