REGRESSION (309405@main): CSS stretch and anonymous wrappers

[annevk]

0b3ed4d

REGRESSION (309405@main): CSS stretch and anonymous wrappers
https://bugs.webkit.org/show_bug.cgi?id=314885
rdar://176398251

Reviewed by NOBODY (OOPS!).

Stretch height calculation should work in the same way as percentage
height calculation, by skipping anonymous wrappers. Not doing this
properly caused at least one website to not render its iframe at
viewport height.

Fix is verified with new tests and behavior matches Chromium and Gecko
(though the latter only when stretch keyword support is enabled).

Tests: imported/w3c/web-platform-tests/css/css-sizing/stretch/stretch-anonymous-block-001.html
       imported/w3c/web-platform-tests/css/css-sizing/stretch/stretch-quirk-002.html

Upstream: web-platform-tests/wpt#59896

0b3ed4d

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		⏳ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	❌ 🧪 mac-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash 0b3ed4d)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		⏳ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	❌ 🧪 mac-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[bfgeek]

I saw this go past the WPT importer - the tests are correct, however you are going to skip past things in quirks mode that aren't correct.

Percentages in quirks mode skip past all auto height things (which is what this function does), stretch should not (we don't want to expand that quirk to stretch).

stretch can resolve against the as due to the "body fills the viewport" quirk it can resolve as definite.

[annevk]

Yeah that’s what the failing test on the bot is pointing out as well. Thanks for the heads up!

[annevk]

Fixed by https://commits.webkit.org/313359@main.