Skip to content

Unreviewed, address unexpected safer cpp failure for WasmConstExprGenerator.cpp on EWS#65085

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
cdumez:314998_wasm_safer_cpp
May 18, 2026
Merged

Unreviewed, address unexpected safer cpp failure for WasmConstExprGenerator.cpp on EWS#65085
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
cdumez:314998_wasm_safer_cpp

Conversation

@cdumez
Copy link
Copy Markdown
Contributor

@cdumez cdumez commented May 18, 2026 •
edited by webkit-early-warning-system
Loading

280445b

Unreviewed, address unexpected safer cpp failure for WasmConstExprGenerator.cpp on EWS
https://bugs.webkit.org/show_bug.cgi?id=314998

* Source/JavaScriptCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations:

Canonical link: https://commits.webkit.org/313386@main

58b6114

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios   🛠 mac ❌ 🛠 wpe   🛠 win ⏳ 🛠 ios-apple
  🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ❌ 🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug ❌ 🛠 gtk3-libwebrtc
✅ 🛠 🧪 jsc-x86-64   🧪 api-ios   🧪 mac-wk1 ❌ 🛠 gtk
✅ 🛠 🧪 jsc-debug-arm64 ✅ 🛠 ios-safer-cpp   🧪 mac-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
✅ 🛠 vision-sim   🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge   🧪 vision-wk2   🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🛠 mac-safer-cpp   🧪 jsc-armv7-tests
  🛠 tv-sim   🧪 mac-site-isolation
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez requested a review from a team as a code owner May 18, 2026 03:58
@cdumez cdumez self-assigned this May 18, 2026
@cdumez cdumez added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label May 18, 2026
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented May 18, 2026 •
edited
Loading

EWS run on current version of this PR (hash 58b6114)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios   🛠 mac ❌ 🛠 wpe   🛠 win ⏳ 🛠 ios-apple
  🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ❌ 🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug ❌ 🛠 gtk3-libwebrtc
✅ 🛠 🧪 jsc-x86-64   🧪 api-ios   🧪 mac-wk1 ❌ 🛠 gtk
✅ 🛠 🧪 jsc-debug-arm64 ✅ 🛠 ios-safer-cpp   🧪 mac-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
✅ 🛠 vision-sim   🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge   🧪 vision-wk2   🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🛠 mac-safer-cpp   🧪 jsc-armv7-tests
  🛠 tv-sim   🧪 mac-site-isolation
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 18, 2026
@cdumez
Unreviewed, address unexpected safer cpp failure for WasmConstExprGen…
280445b 
…erator.cpp on EWS

https://bugs.webkit.org/show_bug.cgi?id=314998

* Source/JavaScriptCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations:

Canonical link: https://commits.webkit.org/313386@main
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

webkit-commit-queue commented May 18, 2026

Committed 313386@main (280445b): https://commits.webkit.org/313386@main

Reviewed commits have been landed. Closing PR #65085 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 280445b into WebKit:main May 18, 2026
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 18, 2026
@webkit-ews-buildbot
Copy link
Copy Markdown
Collaborator

webkit-ews-buildbot commented May 18, 2026

macOS Safer C++ Build #107678 (58b6114)

⚠️ Found 1 fixed file! Please update expectations in Source/[Project]/SaferCPPExpectations by running the following command and update your pull request:

  • Tools/Scripts/update-safer-cpp-expectations -p JavaScriptCore --NoUncountedMemberChecker wasm/WasmConstExprGenerator.cpp --platform macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cdumez cdumez

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cdumez @webkit-early-warning-system @webkit-commit-queue @webkit-ews-buildbot