Replace internals.settings.setStorageBlockingPolicy with WebKitTestRunner header in layout tests#65192
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 2166499) Details |
2166499 to
6d938b6
Compare
Collaborator
|
EWS run on current version of this PR (hash 6d938b6) Details
|
pvollan
approved these changes
May 20, 2026
…nner header in layout tests https://bugs.webkit.org/show_bug.cgi?id=315103 rdar://177440049 Reviewed by Per Arne Vollan. internals.settings.setStorageBlockingPolicy only updates the storage blocking policy in the current web process. Under Site Isolation, this means cross-site subframe processes and the network process do not receive the policy update, leading to inconsistent behavior. Replace runtime JavaScript calls with declarative <!-- webkit-test-runner [ StorageBlockingPolicy=N ] --> headers, which set the policy via WebPreferences before the test begins and propagate it to all processes including the network process. The four dynamic policy change tests (storage-blocking-loosened/strengthened-*) still use the internals API and will be addressed separately. * LayoutTests/http/tests/cache/partitioned-cache-iframe.html: * LayoutTests/http/tests/cache/partitioned-cache.html: * LayoutTests/http/tests/cache/resources/partitioned-cache-loader.html: * LayoutTests/http/tests/navigation/page-cache-pending-image-load-cache-partition.html: * LayoutTests/http/tests/security/credentials-iframes.html: * LayoutTests/http/tests/security/credentials-main-resource.html: * LayoutTests/http/tests/security/cross-origin-indexeddb.html: * LayoutTests/http/tests/security/cross-origin-local-storage-allowed.html: * LayoutTests/http/tests/security/cross-origin-session-storage-third-party-blocked.html: * LayoutTests/http/tests/security/cross-origin-websql.html: * LayoutTests/http/tests/security/cross-origin-worker-indexeddb.html: * LayoutTests/http/tests/security/resources/document-for-cross-origin-worker-indexeddb.html: * LayoutTests/http/tests/security/resources/load-local-storage.html: * LayoutTests/http/tests/security/same-origin-document-domain-storage-allowed.html: * LayoutTests/http/tests/security/same-origin-storage-blocked.html: * LayoutTests/http/tests/security/same-origin-websql-blocked.html: * LayoutTests/http/tests/security/sync-xhr-partition.html: Canonical link: https://commits.webkit.org/313540@main
6d938b6 to
0e486e3
Compare
Collaborator
|
Committed 313540@main (0e486e3): https://commits.webkit.org/313540@main Reviewed commits have been landed. Closing PR #65192 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 vision-apple
0e486e3
6d938b6
🧪 win-tests🧪 ios-wk2-wpt🧪 api-mac-debug🧪 mac-AS-debug-wk2