Skip to content

Replace internals.settings.setStorageBlockingPolicy with WebKitTestRunner header in layout tests#65192

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
szewai:eng/Replace-internals-settings-setStorageBlockingPolicy-with-WebKitTestRunner-header-in-layout-tests
May 20, 2026
Merged

Replace internals.settings.setStorageBlockingPolicy with WebKitTestRunner header in layout tests#65192
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
szewai:eng/Replace-internals-settings-setStorageBlockingPolicy-with-WebKitTestRunner-header-in-layout-tests

Conversation

@szewai
Copy link
Copy Markdown
Contributor

@szewai szewai commented May 19, 2026

0e486e3

Replace internals.settings.setStorageBlockingPolicy with WebKitTestRunner header in layout tests
https://bugs.webkit.org/show_bug.cgi?id=315103
rdar://177440049

Reviewed by Per Arne Vollan.

internals.settings.setStorageBlockingPolicy only updates the storage blocking policy in the current web process. Under
Site Isolation, this means cross-site subframe processes and the network process do not receive the policy update,
leading to inconsistent behavior.

Replace runtime JavaScript calls with declarative <!-- webkit-test-runner [ StorageBlockingPolicy=N ] --> headers, which
set the policy via WebPreferences before the test begins and propagate it to all processes including the network process.

The four dynamic policy change tests (storage-blocking-loosened/strengthened-*) still use the internals API and will be
addressed separately.

* LayoutTests/http/tests/cache/partitioned-cache-iframe.html:
* LayoutTests/http/tests/cache/partitioned-cache.html:
* LayoutTests/http/tests/cache/resources/partitioned-cache-loader.html:
* LayoutTests/http/tests/navigation/page-cache-pending-image-load-cache-partition.html:
* LayoutTests/http/tests/security/credentials-iframes.html:
* LayoutTests/http/tests/security/credentials-main-resource.html:
* LayoutTests/http/tests/security/cross-origin-indexeddb.html:
* LayoutTests/http/tests/security/cross-origin-local-storage-allowed.html:
* LayoutTests/http/tests/security/cross-origin-session-storage-third-party-blocked.html:
* LayoutTests/http/tests/security/cross-origin-websql.html:
* LayoutTests/http/tests/security/cross-origin-worker-indexeddb.html:
* LayoutTests/http/tests/security/resources/document-for-cross-origin-worker-indexeddb.html:
* LayoutTests/http/tests/security/resources/load-local-storage.html:
* LayoutTests/http/tests/security/same-origin-document-domain-storage-allowed.html:
* LayoutTests/http/tests/security/same-origin-storage-blocked.html:
* LayoutTests/http/tests/security/same-origin-websql-blocked.html:
* LayoutTests/http/tests/security/sync-xhr-partition.html:

Canonical link: https://commits.webkit.org/313540@main

6d938b6

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ⏳ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe loading 🛠 vision-apple
🧪 ios-wk2-wpt 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim ✅ 🧪 mac-site-isolation
✅ 🛠 watch
✅ 🛠 watch-sim

@szewai szewai self-assigned this May 19, 2026
@szewai szewai added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label May 19, 2026
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 19, 2026
@szewai szewai removed the merging-blocked Applied to prevent a change from being merged label May 20, 2026
@szewai szewai force-pushed the eng/Replace-internals-settings-setStorageBlockingPolicy-with-WebKitTestRunner-header-in-layout-tests branch from 2166499 to 6d938b6 Compare May 20, 2026 00:18
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 20, 2026
@szewai szewai marked this pull request as ready for review May 20, 2026 03:25
@szewai szewai removed the merging-blocked Applied to prevent a change from being merged label May 20, 2026
@szewai szewai requested review from pvollan and rniwa May 20, 2026 03:25
@szewai szewai added the merge-queue Applied to send a pull request to merge-queue label May 20, 2026
…nner header in layout tests

https://bugs.webkit.org/show_bug.cgi?id=315103
rdar://177440049

Reviewed by Per Arne Vollan.

internals.settings.setStorageBlockingPolicy only updates the storage blocking policy in the current web process. Under
Site Isolation, this means cross-site subframe processes and the network process do not receive the policy update,
leading to inconsistent behavior.

Replace runtime JavaScript calls with declarative <!-- webkit-test-runner [ StorageBlockingPolicy=N ] --> headers, which
set the policy via WebPreferences before the test begins and propagate it to all processes including the network process.

The four dynamic policy change tests (storage-blocking-loosened/strengthened-*) still use the internals API and will be
addressed separately.

* LayoutTests/http/tests/cache/partitioned-cache-iframe.html:
* LayoutTests/http/tests/cache/partitioned-cache.html:
* LayoutTests/http/tests/cache/resources/partitioned-cache-loader.html:
* LayoutTests/http/tests/navigation/page-cache-pending-image-load-cache-partition.html:
* LayoutTests/http/tests/security/credentials-iframes.html:
* LayoutTests/http/tests/security/credentials-main-resource.html:
* LayoutTests/http/tests/security/cross-origin-indexeddb.html:
* LayoutTests/http/tests/security/cross-origin-local-storage-allowed.html:
* LayoutTests/http/tests/security/cross-origin-session-storage-third-party-blocked.html:
* LayoutTests/http/tests/security/cross-origin-websql.html:
* LayoutTests/http/tests/security/cross-origin-worker-indexeddb.html:
* LayoutTests/http/tests/security/resources/document-for-cross-origin-worker-indexeddb.html:
* LayoutTests/http/tests/security/resources/load-local-storage.html:
* LayoutTests/http/tests/security/same-origin-document-domain-storage-allowed.html:
* LayoutTests/http/tests/security/same-origin-storage-blocked.html:
* LayoutTests/http/tests/security/same-origin-websql-blocked.html:
* LayoutTests/http/tests/security/sync-xhr-partition.html:

Canonical link: https://commits.webkit.org/313540@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Replace-internals-settings-setStorageBlockingPolicy-with-WebKitTestRunner-header-in-layout-tests branch from 6d938b6 to 0e486e3 Compare May 20, 2026 04:17
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 313540@main (0e486e3): https://commits.webkit.org/313540@main

Reviewed commits have been landed. Closing PR #65192 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0e486e3 into WebKit:main May 20, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants