Skip to content

[CSS] Add strong CSS types for clip property#65544

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
weinig:eng/clip-property-strong-css
May 24, 2026
Merged

[CSS] Add strong CSS types for clip property#65544
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
weinig:eng/clip-property-strong-css

Conversation

@weinig
Copy link
Copy Markdown
Contributor

@weinig weinig commented May 23, 2026

9b59d6b

[CSS] Add strong CSS types for clip property
https://bugs.webkit.org/show_bug.cgi?id=315430

Reviewed by Darin Adler.

Adds strong CSS types for the clip property.

Also works around #including CSSCalcValue.h in more places by (would
have been needed in CSSClip.cpp) by changing CSSPrimitiveValue to
take the type-erasing CSS::UnevaluatedCalcBase type for construction.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSClipValue.cpp: Added.
* Source/WebCore/css/CSSClipValue.h: Added.
* Source/WebCore/css/CSSPrimitiveValue.cpp:
* Source/WebCore/css/CSSPrimitiveValue.h:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValue.cpp:
* Source/WebCore/css/CSSValue.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Masking.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Masking.h:
* Source/WebCore/css/values/masking/CSSClip.cpp: Added.
* Source/WebCore/css/values/masking/CSSClip.h: Added.
* Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+CSSValueCreation.h:
* Source/WebCore/style/values/masking/StyleClip.cpp:
* Source/WebCore/style/values/masking/StyleClip.h:

Canonical link: https://commits.webkit.org/313815@main

46bd6d8

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
loading-orange 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision loading-orange 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim ✅ 🧪 mac-site-isolation
✅ 🛠 watch
✅ 🛠 watch-sim

@weinig weinig self-assigned this May 23, 2026
@weinig weinig added the CSS Cascading Style Sheets implementation label May 23, 2026
@webkit-early-warning-system

This comment was marked as outdated.

@webkit-ews-buildbot

This comment was marked as outdated.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 23, 2026
@webkit-ews-buildbot

This comment was marked as outdated.

@weinig weinig removed the merging-blocked Applied to prevent a change from being merged label May 24, 2026
@weinig weinig force-pushed the eng/clip-property-strong-css branch from 45fe796 to 28efcb4 Compare May 24, 2026 01:42
@weinig weinig requested review from anttijk and darinadler May 24, 2026 01:42
@weinig weinig marked this pull request as ready for review May 24, 2026 01:43
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 24, 2026
@webkit-ews-buildbot

This comment was marked as outdated.

@webkit-ews-buildbot

This comment was marked as outdated.

@weinig weinig removed the merging-blocked Applied to prevent a change from being merged label May 24, 2026
@weinig weinig force-pushed the eng/clip-property-strong-css branch from 28efcb4 to d4d5fbc Compare May 24, 2026 15:04
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 24, 2026
@weinig weinig removed the merging-blocked Applied to prevent a change from being merged label May 24, 2026
@weinig weinig force-pushed the eng/clip-property-strong-css branch from d4d5fbc to 46bd6d8 Compare May 24, 2026 15:27
@weinig weinig added the merge-queue Applied to send a pull request to merge-queue label May 24, 2026
https://bugs.webkit.org/show_bug.cgi?id=315430

Reviewed by Darin Adler.

Adds strong CSS types for the clip property.

Also works around #including CSSCalcValue.h in more places by (would
have been needed in CSSClip.cpp) by changing CSSPrimitiveValue to
take the type-erasing CSS::UnevaluatedCalcBase type for construction.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSClipValue.cpp: Added.
* Source/WebCore/css/CSSClipValue.h: Added.
* Source/WebCore/css/CSSPrimitiveValue.cpp:
* Source/WebCore/css/CSSPrimitiveValue.h:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValue.cpp:
* Source/WebCore/css/CSSValue.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Masking.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Masking.h:
* Source/WebCore/css/values/masking/CSSClip.cpp: Added.
* Source/WebCore/css/values/masking/CSSClip.h: Added.
* Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+CSSValueCreation.h:
* Source/WebCore/style/values/masking/StyleClip.cpp:
* Source/WebCore/style/values/masking/StyleClip.h:

Canonical link: https://commits.webkit.org/313815@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/clip-property-strong-css branch from 46bd6d8 to 9b59d6b Compare May 24, 2026 18:04
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 313815@main (9b59d6b): https://commits.webkit.org/313815@main

Reviewed commits have been landed. Closing PR #65544 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 9b59d6b into WebKit:main May 24, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CSS Cascading Style Sheets implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants