[CSS] Add strong CSS types for clip property#65544
Merged
webkit-commit-queue merged 1 commit intoMay 24, 2026
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
45fe796 to
28efcb4
Compare
Collaborator
|
EWS run on previous version of this PR (hash 28efcb4) Details |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
darinadler
approved these changes
May 24, 2026
28efcb4 to
d4d5fbc
Compare
Collaborator
|
EWS run on previous version of this PR (hash d4d5fbc) Details |
d4d5fbc to
46bd6d8
Compare
Collaborator
|
EWS run on current version of this PR (hash 46bd6d8) Details |
https://bugs.webkit.org/show_bug.cgi?id=315430 Reviewed by Darin Adler. Adds strong CSS types for the clip property. Also works around #including CSSCalcValue.h in more places by (would have been needed in CSSClip.cpp) by changing CSSPrimitiveValue to take the type-erasing CSS::UnevaluatedCalcBase type for construction. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/css/CSSClipValue.cpp: Added. * Source/WebCore/css/CSSClipValue.h: Added. * Source/WebCore/css/CSSPrimitiveValue.cpp: * Source/WebCore/css/CSSPrimitiveValue.h: * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/CSSValue.cpp: * Source/WebCore/css/CSSValue.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Masking.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Masking.h: * Source/WebCore/css/values/masking/CSSClip.cpp: Added. * Source/WebCore/css/values/masking/CSSClip.h: Added. * Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+CSSValueCreation.h: * Source/WebCore/style/values/masking/StyleClip.cpp: * Source/WebCore/style/values/masking/StyleClip.h: Canonical link: https://commits.webkit.org/313815@main
46bd6d8 to
9b59d6b
Compare
Collaborator
|
Committed 313815@main (9b59d6b): https://commits.webkit.org/313815@main Reviewed commits have been landed. Closing PR #65544 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧪 ios-wk2-wpt
🧪 api-ios
9b59d6b
46bd6d8