Back button not enabled on sciencedirect.com to support Safari's "Close and return to ..." feature for new windows

[beidson]

523b810

Back button not enabled on sciencedirect.com to support Safari's "Close and return to ..." feature for new windows
rdar://177792841
https://bugs.webkit.org/show_bug.cgi?id=315440

Reviewed by Richard Robinson.

Before this change, we add new history items to the back/forward list in one step, then flag them as
"created by JS without user interaction" in a separate step.

The first step performs a delegate callback to notify the app that the bf-list changed.
The app then runs some code based on the bf-list change.

Then the second step updates the items flag, which can change the presentation of the bf-list,
notably by making it shorter by hiding some items.

But the app saw the "incorrect" list already, and already ran code, which might've been destructive.

This patch sets the flag upon initial creation of the history item which removes this interstitial gap.

This allows the app to make its decisions based on an always accurate presentation of the bf-list.

Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKBackForwardListTests.mm

* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadInSameDocument):
* Source/WebCore/loader/HistoryController.cpp:
(WebCore::HistoryController::updateBackForwardListForFragmentScroll):
(WebCore::HistoryController::updateForStandardLoad):
(WebCore::HistoryController::updateBackForwardListClippedAtTarget):
(WebCore::HistoryController::updateBackForwardListForReplaceState):
* Source/WebCore/loader/HistoryController.h:
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKBackForwardListTests.mm:
(-[ItemAddedRecordingDelegate webView:didFinishNavigation:]):
(-[ItemAddedRecordingDelegate _webView:navigation:didSameDocumentNavigation:]):
(-[ItemAddedRecordingDelegate _webView:backForwardListItemAdded:removed:]):
(TEST(WKBackForwardList, ItemAddedDelegateObservesUserGestureFlagAtCallbackTime)):

Canonical link: https://commits.webkit.org/313814@main

6b7554a

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	❌ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	❌ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim	❌ 🧪 mac-site-isolation
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash edd5ebb)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	🛠 gtk3-libwebrtc
	❌ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim	✅ 🧪 mac-site-isolation
	✅ 🛠 watch
	✅ 🛠 watch-sim

[rr-codes]

optional: consider writing this or future tests using Swift Testing, it's much more ergonomic and nicer to use!

[webkit-early-warning-system]

EWS run on current version of this PR (hash 6b7554a)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	❌ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	❌ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim	❌ 🧪 mac-site-isolation
	✅ 🛠 watch
	✅ 🛠 watch-sim

[beidson]

The last EWS run had an apparently-new API test failure on iOS:
TestWebKitAPI.CopyHTML.SanitizationPreservesCharacterSetInSelectedText

The odds that this patch caused that test to fail seem extremely low to me. And also to Claude.
But since I'm addressing some minor review feedback, I'll wait for api-ios to complete again.

[beidson]

The last EWS run had an apparently-new API test failure on iOS: TestWebKitAPI.CopyHTML.SanitizationPreservesCharacterSetInSelectedText

The odds that this patch caused that test to fail seem extremely low to me. And also to Claude. But since I'm addressing some minor review feedback, I'll wait for api-ios to complete again.

Actually, I probably won't even wait... That test does a single synchronous HTML load then never navigates again or introspects the back/forward list. It doesn't plug into the delegate on bflist changes, or do anything else relevant.

[webkit-commit-queue]

Committed 313814@main (523b810): https://commits.webkit.org/313814@main

Reviewed commits have been landed. Closing PR #65548 and removing active labels.

[RupinMittal]

Fixing the build in #65591.