Skip to content

[GStreamer][WebRTC][Rice] imported/w3c/web-platform-tests/webrtc/RTCDataChannel-send-close-array-buffer.window.html flaky crashes#65575

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
philn:eng/315469
May 25, 2026
Merged

Conversation

@philn
Copy link
Copy Markdown
Member

@philn philn commented May 24, 2026 •
edited by webkit-early-warning-system
Loading

f9a8c97

[GStreamer][WebRTC][Rice] imported/w3c/web-platform-tests/webrtc/RTCDataChannel-send-close-array-buffer.window.html flaky crashes
https://bugs.webkit.org/show_bug.cgi?id=315469

Reviewed by Xabier Rodriguez-Calvar.

Protect access to the streams hashmap using a mutex, otherwise we might crash when being notified of
incoming data while a close procedure is on-going.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerIceAgent.cpp:
(webkitGstWebRTCIceAgentAddStream):
(webkitGstWebRTCIceAgentSetTos):
(webkitGstWebRTCIceAgentClosed):
(findStreamAndApply):
(webkitGstWebRTCIceAgentConfigure):
(webkitGstWebRTCIceAgentGatheringDoneForStream):
(webkitGstWebRTCIceAgentLocalCandidateGatheredForStream):
(webkitGstWebRTCIceAgentNewSelectedPairForStream):
(webkitGstWebRTCIceAgentComponentStateChangedForStream):

Canonical link: https://commits.webkit.org/313836@main

43b0407

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim ✅ 🧪 mac-site-isolation
✅ 🛠 watch
✅ 🛠 watch-sim

@philn philn self-assigned this May 24, 2026
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented May 24, 2026 •
edited
Loading

EWS run on previous version of this PR (hash d55354c)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style loading 🛠 ios   🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
  🧪 api-ios   🧪 mac-wk1 ❌ 🛠 gtk
✅ 🛠 ios-safer-cpp   🧪 mac-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
✅ 🛠 vision-sim   🧪 mac-wk2-stress ✅ 🛠 playstation
  🧪 vision-wk2   🧪 mac-intel-wk2
✅ 🛠 tv   🛠 mac-safer-cpp
✅ 🛠 tv-sim   🧪 mac-site-isolation
✅ 🛠 watch
✅ 🛠 watch-sim

@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label May 24, 2026
@philn philn requested a review from calvaris May 24, 2026 19:19
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 24, 2026
@philn philn removed the merging-blocked Applied to prevent a change from being merged label May 24, 2026
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented May 24, 2026 •
edited
Loading

EWS run on previous version of this PR (hash 95c807c)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios loading 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 loading 🧪 api-mac loading 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios loading 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp loading 🧪 mac-wk2 loading-orange 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 loading 🧪 api-gtk
✅ 🛠 vision-sim loading 🧪 mac-wk2-stress ✅ 🛠 playstation
loading 🧪 vision-wk2 loading 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim loading 🧪 mac-site-isolation
✅ 🛠 watch
✅ 🛠 watch-sim

calvaris
calvaris approved these changes May 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@calvaris calvaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crahes -> crashes.

@philn philn changed the title [GStreamer][WebRTC][Rice] imported/w3c/web-platform-tests/webrtc/RTCDataChannel-send-close-array-buffer.window.html flaky crahes [GStreamer][WebRTC][Rice] imported/w3c/web-platform-tests/webrtc/RTCDataChannel-send-close-array-buffer.window.html flaky crashes May 25, 2026
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented May 25, 2026 •
edited
Loading

EWS run on previous version of this PR (hash f7480a9)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim ✅ 🧪 mac-site-isolation
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented May 25, 2026 •
edited
Loading

EWS run on current version of this PR (hash 43b0407)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim ✅ 🧪 mac-site-isolation
✅ 🛠 watch
✅ 🛠 watch-sim

@philn philn added GLib Suggested Backport - 2.52 Suggest this merge request be backported to the webkitglib/2.52 stable branch merge-queue Applied to send a pull request to merge-queue labels May 25, 2026
@philn
[GStreamer][WebRTC][Rice] imported/w3c/web-platform-tests/webrtc/RTCD…
f9a8c97 
…ataChannel-send-close-array-buffer.window.html flaky crashes

https://bugs.webkit.org/show_bug.cgi?id=315469

Reviewed by Xabier Rodriguez-Calvar.

Protect access to the streams hashmap using a mutex, otherwise we might crash when being notified of
incoming data while a close procedure is on-going.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerIceAgent.cpp:
(webkitGstWebRTCIceAgentAddStream):
(webkitGstWebRTCIceAgentSetTos):
(webkitGstWebRTCIceAgentClosed):
(findStreamAndApply):
(webkitGstWebRTCIceAgentConfigure):
(webkitGstWebRTCIceAgentGatheringDoneForStream):
(webkitGstWebRTCIceAgentLocalCandidateGatheredForStream):
(webkitGstWebRTCIceAgentNewSelectedPairForStream):
(webkitGstWebRTCIceAgentComponentStateChangedForStream):

Canonical link: https://commits.webkit.org/313836@main
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

webkit-commit-queue commented May 25, 2026

Committed 313836@main (f9a8c97): https://commits.webkit.org/313836@main

Reviewed commits have been landed. Closing PR #65575 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f9a8c97 into WebKit:main May 25, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 25, 2026
@philn philn deleted the eng/315469 branch May 25, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calvaris calvaris calvaris approved these changes

Assignees

@philn philn

Labels

GLib Suggested Backport - 2.52 Suggest this merge request be backported to the webkitglib/2.52 stable branch Platform Portability improvements and other general platform improvements not driven directly by site bugs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@philn @webkit-early-warning-system @webkit-commit-queue @calvaris @webkit-ews-buildbot