Skip to content

Add missing CSSValue::addDerivedHash implementations to types that formerly were part of CSSPrimitiveValue#65625

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
weinig:eng/Add-missing-CSSValue-addDerivedHash-implementations-to-types-that-formerly-were-part-of-CSSPrimitiveValue
May 26, 2026
Merged

Add missing CSSValue::addDerivedHash implementations to types that formerly were part of CSSPrimitiveValue#65625
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
weinig:eng/Add-missing-CSSValue-addDerivedHash-implementations-to-types-that-formerly-were-part-of-CSSPrimitiveValue

Conversation

@weinig
Copy link
Copy Markdown
Contributor

@weinig weinig commented May 25, 2026

e3c460f

Add missing CSSValue::addDerivedHash implementations to types that formerly were part of CSSPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=315514

Reviewed by Antti Koivisto.

Implements `addDerivedHash` on ident and string-like CSSValue
subtypes that have been extracted from CSSPrimitiveValue by
hooking them up to the `add(Hasher&, {type})` implementations
for their underlying strong type.

This hashing is used by ImmutableStyleProperties::createDeduplicating
to deduplicate style property lists.

* Source/WebCore/css/CSSCustomIdentValue.cpp:
* Source/WebCore/css/CSSCustomIdentValue.h:
* Source/WebCore/css/CSSFontFamilyNameValue.cpp:
* Source/WebCore/css/CSSFontFamilyNameValue.h:
* Source/WebCore/css/CSSKeywordValue.cpp:
* Source/WebCore/css/CSSKeywordValue.h:
* Source/WebCore/css/CSSStringValue.cpp:
* Source/WebCore/css/CSSStringValue.h:

Canonical link: https://commits.webkit.org/313858@main

a5038da

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
loading 🛠 🧪 jsc-x86-64 ✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim ✅ 🧪 mac-site-isolation
✅ 🛠 watch
✅ 🛠 watch-sim

@weinig weinig self-assigned this May 25, 2026
@weinig weinig added the CSS Cascading Style Sheets implementation label May 25, 2026
@weinig weinig marked this pull request as ready for review May 25, 2026 18:46
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 25, 2026
@weinig weinig added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels May 26, 2026
…rmerly were part of CSSPrimitiveValue

https://bugs.webkit.org/show_bug.cgi?id=315514

Reviewed by Antti Koivisto.

Implements `addDerivedHash` on ident and string-like CSSValue
subtypes that have been extracted from CSSPrimitiveValue by
hooking them up to the `add(Hasher&, {type})` implementations
for their underlying strong type.

This hashing is used by ImmutableStyleProperties::createDeduplicating
to deduplicate style property lists.

* Source/WebCore/css/CSSCustomIdentValue.cpp:
* Source/WebCore/css/CSSCustomIdentValue.h:
* Source/WebCore/css/CSSFontFamilyNameValue.cpp:
* Source/WebCore/css/CSSFontFamilyNameValue.h:
* Source/WebCore/css/CSSKeywordValue.cpp:
* Source/WebCore/css/CSSKeywordValue.h:
* Source/WebCore/css/CSSStringValue.cpp:
* Source/WebCore/css/CSSStringValue.h:

Canonical link: https://commits.webkit.org/313858@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Add-missing-CSSValue-addDerivedHash-implementations-to-types-that-formerly-were-part-of-CSSPrimitiveValue branch from a5038da to e3c460f Compare May 26, 2026 00:15
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 313858@main (e3c460f): https://commits.webkit.org/313858@main

Reviewed commits have been landed. Closing PR #65625 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit e3c460f into WebKit:main May 26, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CSS Cascading Style Sheets implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants