Add missing CSSValue::addDerivedHash implementations to types that formerly were part of CSSPrimitiveValue#65625
Merged
Conversation
Collaborator
|
EWS run on current version of this PR (hash a5038da) Details |
anttijk
approved these changes
May 25, 2026
…rmerly were part of CSSPrimitiveValue https://bugs.webkit.org/show_bug.cgi?id=315514 Reviewed by Antti Koivisto. Implements `addDerivedHash` on ident and string-like CSSValue subtypes that have been extracted from CSSPrimitiveValue by hooking them up to the `add(Hasher&, {type})` implementations for their underlying strong type. This hashing is used by ImmutableStyleProperties::createDeduplicating to deduplicate style property lists. * Source/WebCore/css/CSSCustomIdentValue.cpp: * Source/WebCore/css/CSSCustomIdentValue.h: * Source/WebCore/css/CSSFontFamilyNameValue.cpp: * Source/WebCore/css/CSSFontFamilyNameValue.h: * Source/WebCore/css/CSSKeywordValue.cpp: * Source/WebCore/css/CSSKeywordValue.h: * Source/WebCore/css/CSSStringValue.cpp: * Source/WebCore/css/CSSStringValue.h: Canonical link: https://commits.webkit.org/313858@main
a5038da to
e3c460f
Compare
Collaborator
|
Committed 313858@main (e3c460f): https://commits.webkit.org/313858@main Reviewed commits have been landed. Closing PR #65625 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 🧪 jsc-x86-64
e3c460f
a5038da