[GTK][WPE] Limit the damage region of the scrollbar to the region actually painted#66417
Merged
webkit-commit-queue merged 1 commit intoJun 4, 2026
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash fefc36d) Details |
fujii
force-pushed
the
eng/scrollbar-damage-region
branch
from
fefc36d to
d8a143b
Compare
Collaborator
|
EWS run on previous version of this PR (hash d8a143b) Details |
fujii
force-pushed
the
eng/scrollbar-damage-region
branch
from
d8a143b to
9816afc
Compare
Collaborator
|
EWS run on previous version of this PR (hash 9816afc) Details |
| GraphicsContextSkia context(*canvas, RenderingMode::Accelerated, RenderingPurpose::DOM); | ||
| context.scale(contentsScale); | ||
| scrollerImp->paint(context, state.frameRect, state); | ||
| scrollerImp->paint(context, state.frameRect, state, damage); |
Contributor
There was a problem hiding this comment.
Does this work? paint expects a pointer
Contributor
Author
There was a problem hiding this comment.
This calls ScrollerImpAdwaita::paint rather than AdwaitaScrollbarPainter::paint.
| }; | ||
|
|
||
| void paint(GraphicsContext&, const IntRect&, const State&); | ||
| void paint(GraphicsContext&, const IntRect&, const State&, Damage* damageOut = nullptr); |
Contributor
There was a problem hiding this comment.
Would it be possible to use std::optional instead of a pointer?
Contributor
Author
There was a problem hiding this comment.
std::optional<Damage>& ? this is a raw reference. There is no big difference between raw reference and raw pointer. But, a raw pointer can be nullptr.
carlosgcampos
approved these changes
Jun 4, 2026
| void paint(GraphicsContext& graphicsContext, const IntRect& damageRect, const AdwaitaScrollbarPainter::State& state, Damage& damageOut) | ||
| { | ||
| AdwaitaScrollbarPainter::paint(graphicsContext, damageRect, state); | ||
| AdwaitaScrollbarPainter::paint(graphicsContext, damageRect, state, &damageOut); |
Contributor
There was a problem hiding this comment.
Ah, I missed this, here is where we pass the pointer.
webkit-ews-buildbot
added
the
merging-blocked
fujii
force-pushed
the
eng/scrollbar-damage-region
branch
from
9816afc to
ad0aae2
Compare
Collaborator
|
EWS run on current version of this PR (hash ad0aae2) Details |
fujii
added
the
unsafe-merge-queue
…ually painted https://bugs.webkit.org/show_bug.cgi?id=316268 Reviewed by Carlos Garcia Campos. The whole scrollbar layer was always damaged while the overlay scrollbar is hiding even though the most part of the overlay scrollbar is transparent. Only the visible part, scrollbar thumb area, should be damaged during the hiding animaiton. * Source/WebCore/page/scrolling/coordinated/ScrollerCoordinated.cpp: (WebCore::ScrollerCoordinated::updateValues): * Source/WebCore/platform/adwaita/AdwaitaScrollbarPainter.cpp: (WebCore::AdwaitaScrollbarPainter::paint): * Source/WebCore/platform/adwaita/AdwaitaScrollbarPainter.h: * Source/WebCore/platform/adwaita/ScrollerImpAdwaita.h: (WebCore::ScrollerImpAdwaita::paint): * Source/WebCore/platform/graphics/Damage.h: Canonical link: https://commits.webkit.org/314540@main
webkit-commit-queue
force-pushed
the
eng/scrollbar-damage-region
branch
from
ad0aae2 to
0512cc5
Compare
Collaborator
|
Committed 314540@main (0512cc5): https://commits.webkit.org/314540@main Reviewed commits have been landed. Closing PR #66417 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0512cc5
ad0aae2
🧪 win-tests🧪 ios-wk2-wpt🧪 mac-intel-wk2