Skip to content

Make size of input[type="color"] aware of vertical writing mode #6752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-early-warning-system merged 1 commit into from
Nov 23, 2022
Merged

Make size of input[type="color"] aware of vertical writing mode #6752

webkit-early-warning-system merged 1 commit into from
Nov 23, 2022

Conversation

@nt1m
Copy link
Member

@nt1m nt1m commented Nov 23, 2022 •
edited by webkit-early-warning-system
Loading

8786fe4

Make size of input[type="color"] aware of vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=248253
rdar://102616389

Reviewed by Cameron McCormack.

Use logical property counterparts on desktop platforms. Also, enable testing of vertical writing mode controls.

* LayoutTests/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/css/horizontalFormControls.css:
(@namespace "http://www.w3.org/1999/xhtml";;):
* Source/WebCore/css/html.css:
(input:not([type="color"]), textarea, select, button, meter, progress):
(#endif):
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::colorInputStyleSheet const):
* Tools/WebKitTestRunner/TestOptions.cpp:
(WTR::TestOptions::defaults):

Canonical link: https://commits.webkit.org/256967@main

50ad486

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch   🧪 mac-AS-debug-wk2
  🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@nt1m nt1m self-assigned this Nov 23, 2022
@nt1m nt1m added the Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.) label Nov 23, 2022
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 23, 2022 •
edited
Loading

EWS run on previous version of this PR (hash 173b329)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim   🧪 mac-wk2
✅ 🛠 watch   🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

heycam
heycam approved these changes Nov 23, 2022
View reviewed changes
@nt1m nt1m force-pushed the eng/vertical-color-input branch from 173b329 to 50ad486 Compare November 23, 2022 07:11
@nt1m nt1m requested a review from JonWBedard as a code owner November 23, 2022 07:11
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 23, 2022 •
edited
Loading

EWS run on current version of this PR (hash 50ad486)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch   🧪 mac-AS-debug-wk2
  🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@nt1m nt1m added the merge-queue Applied to send a pull request to merge-queue label Nov 23, 2022
@nt1m
Make size of input[type="color"] aware of vertical writing mode
8786fe4 
https://bugs.webkit.org/show_bug.cgi?id=248253
rdar://102616389

Reviewed by Cameron McCormack.

Use logical property counterparts on desktop platforms. Also, enable testing of vertical writing mode controls.

* LayoutTests/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/css/horizontalFormControls.css:
(@namespace "http://www.w3.org/1999/xhtml";):
* Source/WebCore/css/html.css:
(input:not([type="color"]), textarea, select, button, meter, progress):
(#endif):
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::colorInputStyleSheet const):
* Tools/WebKitTestRunner/TestOptions.cpp:
(WTR::TestOptions::defaults):

Canonical link: https://commits.webkit.org/256967@main
@nt1m nt1m added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merge-queue Applied to send a pull request to merge-queue labels Nov 23, 2022
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Nov 23, 2022

Committed 256967@main (8786fe4): https://commits.webkit.org/256967@main

Reviewed commits have been landed. Closing PR #6752 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 8786fe4 into WebKit:main Nov 23, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 23, 2022
@nt1m nt1m deleted the eng/vertical-color-input branch November 23, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heycam heycam heycam approved these changes

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

Assignees

@nt1m nt1m

Labels

Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nt1m @webkit-early-warning-system @webkit-commit-queue @heycam