[web-animations] filter values containing a url() should animate discretely #6754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graouts
added
the
Animations
graouts
changed the title
filter values containing a url() should animate discretely
Collaborator
|
EWS run on previous version of this PR (hash 5869f10) Details
|
graouts
force-pushed
the
filter-discrete-interpolation
branch
from
5869f10 to
d949e4d
Compare
graouts
changed the title
filter values containing a url() should animate discretely
Collaborator
|
EWS run on previous version of this PR (hash d949e4d) Details
|
webkit-ews-buildbot
added
the
merging-blocked
nt1m
approved these changes
Nov 23, 2022
graouts
force-pushed
the
filter-discrete-interpolation
branch
from
d949e4d to
62d795c
Compare
graouts
removed
the
merging-blocked
Collaborator
|
EWS run on previous version of this PR (hash 62d795c) Details |
graouts
added
unsafe-merge-queue
graouts
force-pushed
the
filter-discrete-interpolation
branch
from
62d795c to
fedb5cd
Compare
graouts
added
the
unsafe-merge-queue
Collaborator
|
EWS run on current version of this PR (hash fedb5cd) Details
|
…retely https://bugs.webkit.org/show_bug.cgi?id=248263 Reviewed by Tim Nguyen. We determine when a filter list contains url() and animate discretely in that case. We also simply return either the "from" or "to" value when animating discretely. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/animation/filter-interpolation-003-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt: * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::blendFilterOperations): Canonical link: https://commits.webkit.org/256970@main
webkit-commit-queue
force-pushed
the
filter-discrete-interpolation
branch
from
fedb5cd to
582bdb3
Compare
Collaborator
|
Committed 256970@main (582bdb3): https://commits.webkit.org/256970@main Reviewed commits have been landed. Closing PR #6754 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
582bdb3
fedb5cd
🛠 🧪 win🧪 ios-wk2🧪 gtk-wk2🧪 api-ios🧪 api-mac🧪 api-gtk🧪 mac-wk1🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 mac-wk2-stress