Skip to content

[web-animations] Implement KeyframeEffect.iterationComposite #6812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-early-warning-system merged 1 commit into from
Nov 28, 2022
Merged

[web-animations] Implement KeyframeEffect.iterationComposite #6812

webkit-early-warning-system merged 1 commit into from
Nov 28, 2022

Conversation

@graouts
Copy link
Contributor

@graouts graouts commented Nov 25, 2022 •
edited by webkit-early-warning-system
Loading

5c0978e

[web-animations] Implement KeyframeEffect.iterationComposite
https://bugs.webkit.org/show_bug.cgi?id=246851
rdar://101423139

Reviewed by Antti Koivisto.

Now that all blocking bugs have been resolved and all related WPT tests pass, we can enable
KeyframeEffect.iterationComposite by default.

* Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:

Canonical link: https://commits.webkit.org/257059@main

cb55756

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk1 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 mac-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ❌ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-mips-tests

@graouts graouts self-assigned this Nov 25, 2022
@graouts graouts added the Animations Bugs related to CSS + SVG animations and transitions label Nov 25, 2022
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 25, 2022 •
edited
Loading

EWS run on previous version of this PR (hash 9700a93)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug   🧪 gtk-wk2
⏳ 🧪 api-ios   🧪 api-mac ⏳ 🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ⏳ 🧪 mac-wk1 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim   🧪 mac-wk2   🧪 jsc-armv7-tests
✅ 🛠 watch ⏳ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-mips
✅ 🛠 watch-sim   🧪 mac-wk2-stress   🧪 jsc-mips-tests

@graouts graouts force-pushed the enable-iteration-composite branch from 9700a93 to cb55756 Compare November 25, 2022 10:45
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 25, 2022 •
edited
Loading

EWS run on current version of this PR (hash cb55756)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk1 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 mac-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ❌ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-mips-tests

@graouts graouts changed the title [web-animations] opacity should use unclamped values for from/to keyframes with iterationComposite [web-animations] Implement KeyframeEffect.iterationComposite Nov 25, 2022
@graouts graouts requested review from anttijk and grorg November 25, 2022 10:47
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 25, 2022
anttijk
anttijk approved these changes Nov 26, 2022
View reviewed changes
Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml Outdated
Copy link
Contributor

@anttijk anttijk Nov 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@graouts graouts added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Nov 28, 2022
@graouts
[web-animations] Implement KeyframeEffect.iterationComposite
5c0978e 
https://bugs.webkit.org/show_bug.cgi?id=246851
rdar://101423139

Reviewed by Antti Koivisto.

Now that all blocking bugs have been resolved and all related WPT tests pass, we can enable
KeyframeEffect.iterationComposite by default.

* Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:

Canonical link: https://commits.webkit.org/257059@main
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Nov 28, 2022

Committed 257059@main (5c0978e): https://commits.webkit.org/257059@main

Reviewed commits have been landed. Closing PR #6812 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 5c0978e into WebKit:main Nov 28, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 28, 2022
@graouts graouts deleted the enable-iteration-composite branch November 28, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anttijk anttijk anttijk approved these changes

@grorg grorg Awaiting requested review from grorg

Assignees

@graouts graouts

Labels

Animations Bugs related to CSS + SVG animations and transitions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@graouts @webkit-early-warning-system @webkit-commit-queue @anttijk @webkit-ews-buildbot