Skip to content

Conversation

@philn
Copy link
Member

@philn philn commented Nov 25, 2022

a798257

[GStreamer] Extend colorspace mapping
https://bugs.webkit.org/show_bug.cgi?id=248347

Reviewed by Xabier Rodriguez-Calvar.

GST_VIDEO_COLOR_MATRIX_BT601 was mishandled, it corresponds to SMPTE170M. The
matrix/transfer/primaries mappings now handle most WebCore colorimetry enums.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::videoColorSpaceFromInfo):
(WebCore::fillVideoInfoColorimetryFromColorSpace):

Canonical link: https://commits.webkit.org/257064@main

4b9a952

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@philn philn self-assigned this Nov 25, 2022
@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Nov 25, 2022
@philn philn requested a review from calvaris November 25, 2022 17:33
@philn philn added the merge-queue Applied to send a pull request to merge-queue label Nov 28, 2022
https://bugs.webkit.org/show_bug.cgi?id=248347

Reviewed by Xabier Rodriguez-Calvar.

GST_VIDEO_COLOR_MATRIX_BT601 was mishandled, it corresponds to SMPTE170M. The
matrix/transfer/primaries mappings now handle most WebCore colorimetry enums.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::videoColorSpaceFromInfo):
(WebCore::fillVideoInfoColorimetryFromColorSpace):

Canonical link: https://commits.webkit.org/257064@main
@webkit-commit-queue
Copy link
Collaborator

Committed 257064@main (a798257): https://commits.webkit.org/257064@main

Reviewed commits have been landed. Closing PR #6817 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit a798257 into WebKit:main Nov 28, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 28, 2022
@philn philn deleted the eng/248347 branch November 28, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Platform Portability improvements and other general platform improvements not driven directly by site bugs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants