Increment webpushd protocol version to v2 #7720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnham
added
the
WebKit Misc.
Collaborator
|
EWS run on previous version of this PR (hash c3061c4) Details
|
beidson
approved these changes
Dec 16, 2022
bnham
force-pushed
the
eng/webpushd-ipc-protocol-v2
branch
from
c3061c4 to
36145d9
Compare
Collaborator
|
EWS run on current version of this PR (hash 36145d9) Details
|
webkit-early-warning-system
force-pushed
the
eng/webpushd-ipc-protocol-v2
branch
from
36145d9 to
5d91227
Compare
https://bugs.webkit.org/show_bug.cgi?id=249429 <rdar://problem/103418764> Reviewed by Brady Eidson. We changed the webpushd IPC interface in 257669@main but forgot to increment the version number of the protocol to mark it as non-backwards compatible. This increments the protocol version to 2. * Source/WebKit/Shared/WebPushDaemonConstants.h: * Source/WebKit/webpushd/webpushtool/WebPushToolConnection.mm: (WebPushTool::Connection::startDebugStreamAction): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/258036@main
webkit-early-warning-system
force-pushed
the
eng/webpushd-ipc-protocol-v2
branch
from
5d91227 to
1699ee8
Compare
Collaborator
|
Committed 258036@main (1699ee8): https://commits.webkit.org/258036@main Reviewed commits have been landed. Closing PR #7720 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1699ee8
36145d9
🧪 api-ios🧪 mac-wk1🧪 api-gtk🧪 mac-wk2🧪 mac-AS-debug-wk2