Skip to content

Conversation

@philn
Copy link
Member

@philn philn commented Jan 2, 2023

776ff1f

[GStreamer] Misc fixes in video encoder/decoder probing support
https://bugs.webkit.org/show_bug.cgi?id=249995

Reviewed by Xabier Rodriguez-Calvar.

When multiple elements were able to support the given format only the first matching element factory
was stored in the lookup result. We also now ignore the vpxalphadecodebin wrapper elements when
probing vpx decoding capabilities. Those elements are meant to be used by decodebin and won't
negotiate input non-alpha caps.

* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::ElementFactories::hasElementForMediaType const):
(WebCore::GStreamerRegistryScanner::initializeDecoders):

Canonical link: https://commits.webkit.org/258657@main

8235c3e

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@philn philn self-assigned this Jan 2, 2023
@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Jan 2, 2023
@philn philn requested a review from calvaris January 2, 2023 10:11
@philn philn added the WebRTC For bugs in WebRTC label Jan 9, 2023
@philn philn added the merge-queue Applied to send a pull request to merge-queue label Jan 9, 2023
https://bugs.webkit.org/show_bug.cgi?id=249995

Reviewed by Xabier Rodriguez-Calvar.

When multiple elements were able to support the given format only the first matching element factory
was stored in the lookup result. We also now ignore the vpxalphadecodebin wrapper elements when
probing vpx decoding capabilities. Those elements are meant to be used by decodebin and won't
negotiate input non-alpha caps.

* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::ElementFactories::hasElementForMediaType const):
(WebCore::GStreamerRegistryScanner::initializeDecoders):

Canonical link: https://commits.webkit.org/258657@main
@webkit-commit-queue
Copy link
Collaborator

Committed 258657@main (776ff1f): https://commits.webkit.org/258657@main

Reviewed commits have been landed. Closing PR #8126 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 9, 2023
@webkit-commit-queue webkit-commit-queue merged commit 776ff1f into WebKit:main Jan 9, 2023
@philn philn deleted the eng/249995 branch January 9, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Platform Portability improvements and other general platform improvements not driven directly by site bugs. WebRTC For bugs in WebRTC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants