Shrink Layout::ElementBox slightly #9424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smfr
added
the
Layout and Rendering
alanbaradlay
reviewed
Feb 1, 2023
Comment on lines
+93
to
+95
alanbaradlay
approved these changes
Feb 1, 2023
Collaborator
|
EWS run on current version of this PR (hash 6bbd39c) Details
|
https://bugs.webkit.org/show_bug.cgi?id=251475 rdar://104894626 Reviewed by Alan Baradlay. Shrink Layout::ElementBox from 184 bytes (13 bytes of padding) to 176 bytes (5 bytes of padding) by shifting the bitfields in Box up into the spare 4 bytes between CanMakeCheckedPtr's m_count and m_style. * Source/WebCore/layout/layouttree/LayoutBox.cpp: (WebCore::Layout::Box::Box): * Source/WebCore/layout/layouttree/LayoutBox.h: * Source/WebCore/layout/layouttree/LayoutElementBox.h: * Source/WebCore/rendering/style/RenderStyle.cpp: Canonical link: https://commits.webkit.org/259688@main
webkit-early-warning-system
force-pushed
the
eng/Shrink-LayoutElementBox-slightly
branch
from
6bbd39c to
1b555d0
Compare
Collaborator
|
Committed 259688@main (1b555d0): https://commits.webkit.org/259688@main Reviewed commits have been landed. Closing PR #9424 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1b555d0
6bbd39c
🛠 wincairo🧪 api-gtk🧪 mac-AS-debug-wk2