[WebAuthn] Conditional passkey request presents conditional control even after AbortController.abort()#9449
Merged
webkit-early-warning-system merged 1 commit intoWebKit:mainfrom Feb 2, 2023
Conversation
pascoej
added
the
Forms
Collaborator
|
EWS run on previous version of this PR (hash 75e7bf4) Details
|
Member
|
Nits.
Currently its |
brentfulgham
approved these changes
Feb 1, 2023
Contributor
brentfulgham
left a comment
brentfulgham
left a comment
There was a problem hiding this comment.
Looks good, but please correct the minor nits before landing.
Contributor
There was a problem hiding this comment.
Nit: Should only be one line of whitespace
pascoej
force-pushed
the
eng/WebAuthn-Conditional-passkey-request-presents-conditional-control-even-after-AbortController-abort
branch
from
75e7bf4 to
d32eea9
Compare
Collaborator
|
EWS run on current version of this PR (hash d32eea9) Details
|
webkit-ews-buildbot
added
the
merging-blocked
pascoej
added
merge-queue
…ven after AbortController.abort() https://bugs.webkit.org/show_bug.cgi?id=250589 rdar://99535627 Reviewed by Brent Fulgham. Currently conditional mediation requests do not get cancelled whenever the abort controller for its request is called. This patch changes that by calling cancel on the daemon whenever the abort controller is called. * Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp: (WebCore::AuthenticatorCoordinator::discoverFromExternalSource): * Source/WebCore/Modules/webauthn/AuthenticatorCoordinatorClient.h: * Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp: (WebKit::WebAuthenticatorCoordinatorProxy::cancel): * Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h: * Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in: * Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp: (WebKit::WebAuthenticatorCoordinator::cancel): * Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.h: Canonical link: https://commits.webkit.org/259754@main
webkit-early-warning-system
force-pushed
the
eng/WebAuthn-Conditional-passkey-request-presents-conditional-control-even-after-AbortController-abort
branch
from
d32eea9 to
ba76ae8
Compare
Collaborator
|
Committed 259754@main (ba76ae8): https://commits.webkit.org/259754@main Reviewed commits have been landed. Closing PR #9449 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ba76ae8
d32eea9