-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add an explicit method to getUserCTM() to GraphicsContext #9739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shallawa
wants to merge
1
commit into
WebKit:main
Choose a base branch
from
shallawa:eng/Add-an-explicit-method-to-getUserCTM-to-GraphicsContext
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add an explicit method to getUserCTM() to GraphicsContext #9739
shallawa
wants to merge
1
commit into
WebKit:main
from
shallawa:eng/Add-an-explicit-method-to-getUserCTM-to-GraphicsContext
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Collaborator
|
EWS run on previous version of this PR (hash bf0396f)
|
bf0396f to
12f8cd1
Compare
Collaborator
|
EWS run on previous version of this PR (hash 12f8cd1)
|
https://bugs.webkit.org/show_bug.cgi?id=251839 rdar://105115245 Reviewed by NOBODY (OOPS!). Make getCTM return the effective scale factor which is the multiplication of the baseCTM and the userCTM. Remove the input argument IncludeDeviceScale since it is confusing. Make another explicit method which returns the userCTM. * Source/WebCore/html/CustomPaintImage.cpp: (WebCore::CustomPaintImage::drawPattern): * Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp: (WebCore::BifurcatedGraphicsContext::getCTM const): (WebCore::BifurcatedGraphicsContext::getUserCTM const): * Source/WebCore/platform/graphics/BifurcatedGraphicsContext.h: * Source/WebCore/platform/graphics/FontCascade.cpp: (WebCore::FontCascade::displayListForTextRun const): * Source/WebCore/platform/graphics/GradientImage.cpp: (WebCore::GradientImage::drawPattern): * Source/WebCore/platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::scaleFactor const): (WebCore::GraphicsContext::scaleFactorForDrawing const): (WebCore::GraphicsContext::computeLineBoundsAndAntialiasingModeForText): * Source/WebCore/platform/graphics/GraphicsContext.h: (WebCore::GraphicsContext::getUserCTM const): * Source/WebCore/platform/graphics/NullGraphicsContext.h: * Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContextCairo::getCTM const): * Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.h: * Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContextCG::applyStrokePattern): (WebCore::GraphicsContextCG::applyFillPattern): (WebCore::GraphicsContextCG::setCGShadow): (WebCore::GraphicsContextCG::getCTM const): (WebCore::GraphicsContextCG::getUserCTM const): (WebCore::getUserToBaseCTM): Deleted. * Source/WebCore/platform/graphics/cg/GraphicsContextCG.h: * Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp: (WebCore::DisplayList::Recorder::getCTM const): (WebCore::DisplayList::Recorder::getUserCTM const): * Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h: * Source/WebCore/platform/graphics/mac/controls/ControlMac.mm: (WebCore::ControlMac::drawCell): * Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp: (Nicosia::CairoOperationRecorder::getCTM const): * Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h: * Source/WebCore/rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::bufferForeground): * Source/WebCore/rendering/svg/SVGRenderingContext.cpp: (WebCore::SVGRenderingContext::bufferForeground): * Source/WebKit/Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.mm: * Tools/TestWebKitAPI/Tests/WebCore/cg/BifurcatedGraphicsContextTestsCG.cpp: (TestWebKitAPI::TEST):
12f8cd1 to
e54cbab
Compare
Collaborator
|
EWS run on current version of this PR (hash e54cbab)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e54cbab
e54cbab