Use static port for internal webinspector communication#1125
Merged
magomez merged 1 commit intoWebPlatformForEmbedded:wpe-2.38from Jul 17, 2023
Merged
Conversation
magomez
reviewed
Jul 17, 2023
| if (port > std::numeric_limits<uint16_t>::max()) { | ||
| g_warning("WEBKIT_INSPECTOR_PORT is out of range: %s. Falling back to dynamic port", inspectorPortStr); | ||
| port = 0; | ||
| } |
There was a problem hiding this comment.
This should be replaced with:
String envVar = String::fromLatin1(getenv("WEBKIT_INSPECTOR_PORT"));
auto port = parseInteger<uint16_t>(envVar).value_or(0);
You can check whether port is 0 after this if you want to log the warning that we're falling back to a dynamic port.
You may need to include <wtf/text/StringToIntegerConversion.h> for it to work.
Author
There was a problem hiding this comment.
Thanks, done.
port will also be 0 if env does not exist or if it's set to "0". Lets skip the log, it's unlikely anyway
With this port being dynamic, it's not possible to add specific iptables rules allowing this traffic - and with restrictive rules this traffic may be blocked. Allow selecting the port - controlled by WEBKIT_INSPECTOR_PORT env
jacek-manko-red
force-pushed
the
jmanko/webinspector_internal_port
branch
from
faa40f1 to
21f55e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this port being dynamic, it's not possible to add specific iptables rules allowing this traffic - and with restrictive rules this traffic may be blocked. Allow selecting the port - controlled by WEBKIT_INSPECTOR_PORT env