Skip to content

[MSE SourceBuffer] Disable audio flush on samples replacement for Spo…#1244

Merged
eocanha merged 1 commit intoWebPlatformForEmbedded:wpe-2.38from
asurdej-comcast:audio_only_flush
Dec 21, 2023
Merged

[MSE SourceBuffer] Disable audio flush on samples replacement for Spo…#1244
eocanha merged 1 commit intoWebPlatformForEmbedded:wpe-2.38from
asurdej-comcast:audio_only_flush

Conversation

@asurdej-comcast
Copy link
Copy Markdown

…tify

With edit lists enabled recently, Spotify started to append the same segment multiple times that to samples replacement and audio flush. As a result audio is breaking on every append.

Disable audio flush on samples replacement for Spotify until this is fixed by Spotify

…tify

With edit lists enabled recently, Spotify started to append
the same segment multiple times that to samples replacement
and audio flush. As a result audio is breaking on every append.

Disable audio flush on samples replacement for Spotify
until this is fixed by Spotify
@emutavchi emutavchi requested a review from modeveci November 29, 2023 14:12
@modeveci modeveci requested a review from eocanha November 30, 2023 14:44
@eocanha eocanha merged commit 85f3f00 into WebPlatformForEmbedded:wpe-2.38 Dec 21, 2023
@eocanha
Copy link
Copy Markdown
Member

eocanha commented Dec 21, 2023

The PR is fine. Merging.
It's not upstreamable because the Edit List support is currently reverted upstream, as well as in wpe-2.42.

asurdej-comcast added a commit to asurdej-comcast/WPEWebKit that referenced this pull request Jul 15, 2025
…tify (WebPlatformForEmbedded#1244)

With edit lists enabled recently, Spotify started to append
the same segment multiple times that to samples replacement
and audio flush. As a result audio is breaking on every append.

Disable audio flush on samples replacement for Spotify
until this is fixed by Spotify
eocanha pushed a commit that referenced this pull request Jul 15, 2025
…tify (#1244)

With edit lists enabled recently, Spotify started to append
the same segment multiple times that to samples replacement
and audio flush. As a result audio is breaking on every append.

Disable audio flush on samples replacement for Spotify
until this is fixed by Spotify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants