Skip to content

Fix LTO build#1254

Merged
magomez merged 3 commits intoWebPlatformForEmbedded:wpe-2.38from
emutavchi:wpe-2.38-lto
Dec 15, 2023
Merged

Fix LTO build#1254
magomez merged 3 commits intoWebPlatformForEmbedded:wpe-2.38from
emutavchi:wpe-2.38-lto

Conversation

@emutavchi
Copy link
Copy Markdown
Collaborator

@emutavchi emutavchi commented Dec 11, 2023

This PR:

  • fixes link failure complaining about missing vtable entry for 'RTCDataChannel::~RTCDataChannel'
  • removes compilation of test binaries in libwebrtc
  • removes duplication of compilation of files already included in Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/bcm.c
  • changes the type of PAL library to object for WPE platform

@emutavchi emutavchi requested a review from modeveci December 11, 2023 19:11
@modeveci modeveci requested a review from magomez December 12, 2023 11:04
@magomez magomez merged commit a7a71c4 into WebPlatformForEmbedded:wpe-2.38 Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@modeveci modeveci Awaiting requested review from modeveci

@magomez magomez Awaiting requested review from magomez

Assignees

No one assigned

Labels

wpe-2.38

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emutavchi @magomez @modeveci