Skip to content

[wpe-2.38] Prevent journal files from wasting disk space#1280

Merged
magomez merged 1 commit intoWebPlatformForEmbedded:wpe-2.38from
Scony:journal-size-limit-238
Feb 6, 2024
Merged

[wpe-2.38] Prevent journal files from wasting disk space#1280
magomez merged 1 commit intoWebPlatformForEmbedded:wpe-2.38from
Scony:journal-size-limit-238

Conversation

@Scony
Copy link
Copy Markdown

@Scony Scony commented Jan 26, 2024

I'd like to gather some feedback on potential setting of PRAGMA journal_size_limit = 0; in local storage's SQLite database.
What it does, is slightly improving the effectiveness of disk space usage at the slight expense of performance.
I was wondering if it's maybe worth adding it behind some flag being controlled from settings perhaps?

@magomez
Copy link
Copy Markdown

magomez commented Feb 6, 2024

I don't have a strong opinion for or against this. If saving space is a priority, we could add it, as I don't think the performance penalty is going to be that relevant. @modeveci what do you think?

@modeveci
Copy link
Copy Markdown

modeveci commented Feb 6, 2024

@magomez as you stated that the performance will not be relevant, then it is good to gain from diskspace. sure let's add it.
this is what I have seen from provided description: "To always truncate rollback journals and WAL files to their minimum size, set the journal_size_limit to zero. "

@magomez magomez merged commit bfc66f1 into WebPlatformForEmbedded:wpe-2.38 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants