[wpe-2.38] Prevent journal files from wasting disk space#1280
Merged
magomez merged 1 commit intoWebPlatformForEmbedded:wpe-2.38from Feb 6, 2024
Merged
[wpe-2.38] Prevent journal files from wasting disk space#1280magomez merged 1 commit intoWebPlatformForEmbedded:wpe-2.38from
magomez merged 1 commit intoWebPlatformForEmbedded:wpe-2.38from
Conversation
|
I don't have a strong opinion for or against this. If saving space is a priority, we could add it, as I don't think the performance penalty is going to be that relevant. @modeveci what do you think? |
|
@magomez as you stated that the performance will not be relevant, then it is good to gain from diskspace. sure let's add it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to gather some feedback on potential setting of
PRAGMA journal_size_limit = 0;in local storage's SQLite database.What it does, is slightly improving the effectiveness of disk space usage at the slight expense of performance.
I was wondering if it's maybe worth adding it behind some flag being controlled from settings perhaps?