Images with loading="lazy" have uncontrollable gray border while load…#1418
Merged
magomez merged 1 commit intoWebPlatformForEmbedded:wpe-2.38from Dec 10, 2024
Merged
Conversation
…ing https://bugs.webkit.org/show_bug.cgi?id=243601 Reviewed by Darin Adler. Do not paint border while an image is in deferred state. The test image-loading-lazy-slow.html covers this. However, the current test runner logic stops page loads before making a pixel snapshot, causing the image to be painted as a broken image instead of the empty image at the time of calling takeScreenshot. To fix this, postpone the stopping of page loads and instead always stop page loads when reseting after the test. Note that printing tests are not affected since they already made a pixel snapshot before stopping the page loads. * LayoutTests/TestExpectations: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-wk1/TestExpectations: * Source/WebCore/rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced): * Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): (WTR::InjectedBundle::done): Canonical link: https://commits.webkit.org/253960@main
magomez
approved these changes
Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ing https://bugs.webkit.org/show_bug.cgi?id=243601
Reviewed by Darin Adler.
Do not paint border while an image is in deferred state. The test image-loading-lazy-slow.html covers this. However, the current test runner logic stops page loads before making a pixel snapshot, causing the image to be painted as a broken image instead of the empty image at the time of calling takeScreenshot. To fix this, postpone the stopping of page loads and instead always stop page loads when reseting after the test.
Note that printing tests are not affected since they already made a pixel snapshot before stopping the page loads.
(WTR::InjectedBundle::done):
Canonical link: https://commits.webkit.org/253960@main
Cherry pick of WebKit/WebKit@7d844a4