Skip to content

Added API to get and set screen-supports-HDR setting#1448

Merged
magomez merged 1 commit intowpe-2.38from
pgorszkowski/2.38/screen_supports_HDR
Jan 22, 2025
Merged

Added API to get and set screen-supports-HDR setting#1448
magomez merged 1 commit intowpe-2.38from
pgorszkowski/2.38/screen_supports_HDR

Conversation

@pgorszkowski-igalia
Copy link
Copy Markdown

No description provided.


WEBKIT_API void
webkit_settings_set_screen_supports_hdr (WebKitSettings* settings,
const gboolean screenSupportsHDR);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My personal preference is to avoid const for simple data type arguments

Suggested change
const gboolean screenSupportsHDR);
gboolean screenSupportsHDR);

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and it will be consistent with other similar functions. I will correct it. Thanks

*
*/
void
webkit_settings_set_screen_supports_hdr(WebKitSettings* settings, const gboolean screenSupportsHDR)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
webkit_settings_set_screen_supports_hdr(WebKitSettings* settings, const gboolean screenSupportsHDR)
webkit_settings_set_screen_supports_hdr(WebKitSettings* settings, gboolean screenSupportsHDR)

@pgorszkowski-igalia pgorszkowski-igalia force-pushed the pgorszkowski/2.38/screen_supports_HDR branch from 6f3dcc7 to ae22d69 Compare January 22, 2025 10:00
@magomez magomez merged commit 4fe8840 into wpe-2.38 Jan 22, 2025
@magomez magomez deleted the pgorszkowski/2.38/screen_supports_HDR branch January 22, 2025 10:40
amol-virnodkar-infosys added a commit to LibertyGlobal/WPEWebKit that referenced this pull request Jul 28, 2025
…mic-range: high)") always returns matches=False

Pull request from upstream: WebPlatformForEmbedded#1448
amol-virnodkar-infosys added a commit to LibertyGlobal/WPEWebKit that referenced this pull request Aug 12, 2025
amol-virnodkar-infosys added a commit to LibertyGlobal/WPEWebKit that referenced this pull request Aug 12, 2025
…implementation for RDK platform

Fix for tickets: ARRISEOS-46916, ARRISEOS-46989
Upstream PR: WebPlatformForEmbedded#1448
meecash pushed a commit to LibertyGlobal/WPEWebKit that referenced this pull request Aug 13, 2025
…implementation for RDK platform (#513)

Fix for tickets: ARRISEOS-46916, ARRISEOS-46989
Upstream PR: WebPlatformForEmbedded#1448
marcin-mielczarczyk-red pushed a commit to LibertyGlobal/WPEWebKit that referenced this pull request Oct 7, 2025
…implementation for RDK platform (#513)

Fix for tickets: ARRISEOS-46916, ARRISEOS-46989
Upstream PR: WebPlatformForEmbedded#1448
pradeep-raveendranpillai-infosys pushed a commit to LibertyGlobal/WPEWebKit that referenced this pull request Jan 16, 2026
…implementation for RDK platform (#513)

Fix for tickets: ARRISEOS-46916, ARRISEOS-46989
Upstream PR: WebPlatformForEmbedded#1448
pradeep-raveendranpillai-infosys pushed a commit to LibertyGlobal/WPEWebKit that referenced this pull request Jan 16, 2026
…implementation for RDK platform (#513)

Fix for tickets: ARRISEOS-46916, ARRISEOS-46989
Upstream PR: WebPlatformForEmbedded#1448
pradeep-raveendranpillai-infosys pushed a commit to LibertyGlobal/WPEWebKit that referenced this pull request Jan 19, 2026
…implementation for RDK platform (#513)

Fix for tickets: ARRISEOS-46916, ARRISEOS-46989
Upstream PR: WebPlatformForEmbedded#1448
pradeep-raveendranpillai-infosys pushed a commit to LibertyGlobal/WPEWebKit that referenced this pull request Apr 13, 2026
…implementation for RDK platform (#513)

Fix for tickets: ARRISEOS-46916, ARRISEOS-46989
Upstream PR: WebPlatformForEmbedded#1448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants