Skip to content

Revert "[offscreenCanvas] Take WebGL's rendered textures directly to …#1467

Merged
magomez merged 1 commit intowpe-2.38from
pgorszkowski/2.38/revert_offscreenCanvas_take_webgl_rendered_textures_to_the_compositor_instead_of_copying
Feb 26, 2025
Merged

Revert "[offscreenCanvas] Take WebGL's rendered textures directly to …#1467
magomez merged 1 commit intowpe-2.38from
pgorszkowski/2.38/revert_offscreenCanvas_take_webgl_rendered_textures_to_the_compositor_instead_of_copying

Conversation

@pgorszkowski-igalia
Copy link
Copy Markdown

@pgorszkowski-igalia pgorszkowski-igalia commented Feb 26, 2025 •
edited by ews-bot-wpe-rdk
Loading

…the compositor instead of copying."

This reverts commit 871c426.

The change 871c426 causes the crash when we create OffScreenCanvas and get the "WebGL" context:

var offscreen = new OffscreenCanvas(64, 64);
var context = offscreen.getContext('webgl');

835ea60

Build-Tests Layout-Tests
✅ 🛠 wpe-238-amd64-build ✅ 🧪 wpe-238-amd64-layout
✅ 🛠 wpe-238-arm32-build ✅ 🧪 wpe-238-arm32-layout

@pgorszkowski-igalia
Revert "[offscreenCanvas] Take WebGL's rendered textures directly to …
835ea60 
…the compositor instead of copying."

This reverts commit 871c426.
@magomez magomez merged commit b690a08 into wpe-2.38 Feb 26, 2025
@magomez magomez deleted the pgorszkowski/2.38/revert_offscreenCanvas_take_webgl_rendered_textures_to_the_compositor_instead_of_copying branch February 26, 2025 08:57
simi-mathew added a commit to rdkcentral/meta-rdk-video that referenced this pull request Nov 7, 2025
@simi-mathew
RDKEMW-10264: Sky Store web app crashes
aa557d2 
Reason for change: commit
WebPlatformForEmbedded/WPEWebKit@871c426
results in a crash when we create OffScreenCanvas and get the "WebGL"
context. This patch
reverts the offending commit - patch from upstream wpe webkit -
WebPlatformForEmbedded/WPEWebKit#1467
Test Procedure: Launch SkyStoreDE app without widget
workaround and no crash should be seen. Other test guidance has been
mentioned in the ticket.
Risks: Low
Priority: P0
@simi-mathew simi-mathew mentioned this pull request Nov 7, 2025
Merged
simi-mathew added a commit to rdkcentral/meta-rdk-video that referenced this pull request Nov 10, 2025
@simi-mathew
RDKEMW-10264: Sky Store web app crashes
054a88d 
Reason for change: commit
WebPlatformForEmbedded/WPEWebKit@871c426
results in a crash when we create OffScreenCanvas and get the "WebGL"
context. This patch
reverts the offending commit - patch from upstream wpe webkit -
WebPlatformForEmbedded/WPEWebKit#1467
Test Procedure: Launch SkyStoreDE app without widget
workaround and no crash should be seen. Other test guidance has been
mentioned in the ticket.
Risks: Low
Priority: P0
@simi-mathew simi-mathew mentioned this pull request Nov 10, 2025
Merged
simi-mathew added a commit to rdkcentral/meta-rdk-video that referenced this pull request Nov 10, 2025
@simi-mathew
RDKEMW-10264: Sky Store web app crashes
d87048a 
Reason for change: RDKEMW-10264 commit
WebPlatformForEmbedded/WPEWebKit@871c426
results in a crash when we create OffScreenCanvas and get the "WebGL"
context. This patch
reverts the offending commit - patch from upstream wpe webkit -
WebPlatformForEmbedded/WPEWebKit#1467
Test Procedure: Launch SkyStoreDE app without widget
workaround and no crash should be seen. Other test guidance has been
mentioned in the ticket.
Risks: Low
Priority: P0
simi-mathew added a commit to rdkcentral/meta-rdk-video that referenced this pull request Nov 10, 2025
@simi-mathew
RDKEMW-10264: Sky Store web app crashes
069b5bc 
Reason for change: RDKEMW-10264 commit
WebPlatformForEmbedded/WPEWebKit@871c426
results in a crash when we create OffScreenCanvas and get the "WebGL"
context. This patch
reverts the offending commit - patch from upstream wpe webkit -
WebPlatformForEmbedded/WPEWebKit#1467
Test Procedure: Launch SkyStoreDE app without widget
workaround and no crash should be seen. Other test guidance has been
mentioned in the ticket.
Risks: Low
Priority: P0
simi-mathew added a commit to rdkcentral/meta-rdk-video that referenced this pull request Nov 10, 2025
@simi-mathew
RDKEMW-10309: Sky Store web app crashes
3377c46 
Reason for change: RDKEMW-10309 commit
WebPlatformForEmbedded/WPEWebKit@871c426
results in a crash when we create OffScreenCanvas and get the "WebGL"
context. This patch
reverts the offending commit - patch from upstream wpe webkit -
WebPlatformForEmbedded/WPEWebKit#1467
Test Procedure: Launch SkyStoreDE app without widget
workaround and no crash should be seen. Other test guidance has been
mentioned in the ticket.
Risks: Low
Priority: P0
simi-mathew added a commit to rdkcentral/meta-rdk-video that referenced this pull request Nov 10, 2025
@simi-mathew
RDKEMW-10264: Sky Store web app crashes
7549cca 
Reason for change: commit
WebPlatformForEmbedded/WPEWebKit@871c426
results in a crash when we create OffScreenCanvas and get the "WebGL"
context. This patch
reverts the offending commit - patch from upstream wpe webkit -
WebPlatformForEmbedded/WPEWebKit#1467
Test Procedure: Launch SkyStoreDE app without widget
workaround and no crash should be seen. Other test guidance has been
mentioned in the ticket.
Risks: Low
Priority: P0
@simi-mathew simi-mathew mentioned this pull request Nov 10, 2025
Merged
simi-mathew added a commit to rdkcentral/meta-rdk-video that referenced this pull request Nov 10, 2025
@simi-mathew
RDKEMW-10267: Sky Store web app crashes
2b78583 
Reason for change: commit
WebPlatformForEmbedded/WPEWebKit@871c426
results in a crash when we create OffScreenCanvas and get the "WebGL"
context. This patch
reverts the offending commit - patch from upstream wpe webkit -
WebPlatformForEmbedded/WPEWebKit#1467
Test Procedure: Launch SkyStoreDE app without widget
workaround and no crash should be seen. Other test guidance has been
mentioned in the ticket.
Risks: Low
Priority: P0
simi-mathew added a commit to rdkcentral/meta-rdk-video that referenced this pull request Nov 10, 2025
@simi-mathew
RDKEMW-10325: 8.3 Sky Store web app crashes
7b0a1ba 
Reason for change: commit
WebPlatformForEmbedded/WPEWebKit@871c426
results in a crash when we create OffScreenCanvas and get the "WebGL"
context. This patch
reverts the offending commit - patch from upstream wpe webkit -
WebPlatformForEmbedded/WPEWebKit#1467
Test Procedure: Launch SkyStoreDE app without widget
workaround and no crash should be seen. Other test guidance has been
mentioned in the ticket.
Risks: Low
Priority: P0
@simi-mathew simi-mathew mentioned this pull request Nov 10, 2025
Merged
This was referenced Nov 10, 2025
Merged
Merged
Merged
simi-mathew added a commit to rdkcentral/meta-rdk-video that referenced this pull request Nov 13, 2025
@simi-mathew
RDKEMW-10309: Sky Store web app crashes
127a7cf 
Reason for change: RDKEMW-10309 commit
WebPlatformForEmbedded/WPEWebKit@871c426
results in a crash when we create OffScreenCanvas and get the "WebGL"
context. This patch
reverts the offending commit - patch from upstream wpe webkit -
WebPlatformForEmbedded/WPEWebKit#1467
Test Procedure: Launch SkyStoreDE app without widget
workaround and no crash should be seen. Other test guidance has been
mentioned in the ticket.
Risks: Low
Priority: P0
@rdkcm-rdke rdkcm-rdke mentioned this pull request Nov 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@magomez magomez magomez approved these changes

@zdobersek zdobersek Awaiting requested review from zdobersek

Assignees

No one assigned

Labels

wpe-2.38

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pgorszkowski-igalia @magomez