Skip to content

[JSC] Work around GCC miscompilation in testmasm #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magomez merged 1 commit into from
Feb 18, 2026
Merged

[JSC] Work around GCC miscompilation in testmasm #1621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Source/cmake/WebKitCompilerFlags.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,16 @@ if (COMPILER_IS_GCC_OR_CLANG)
WEBKIT_PREPEND_GLOBAL_COMPILER_FLAGS(-Wno-uninitialized)
endif ()

# Older GCC versions sometimes miscompile switches with that flag on.
# Observed in testMoveConditionallyFloatingPointSameArg (testmasm), turn it
# off throughout to avoid hard-to-diagnose bugs.
if (CMAKE_CXX_COMPILER_ID MATCHES "GNU")
# This and later versions don't seem to exhibit the issue.
if (${CMAKE_CXX_COMPILER_VERSION} VERSION_LESS "14.0.1")
WEBKIT_PREPEND_GLOBAL_COMPILER_FLAGS(-fno-unswitch-loops)
endif ()
endif ()

WEBKIT_PREPEND_GLOBAL_CXX_FLAGS(-Wno-noexcept-type)

# These GCC warnings produce too many false positives to be useful. We'll
Expand Down