disallow rialtomseaudio in webaudio#1680
Open
BunioFH wants to merge 1 commit into
Open
Conversation
BunioFH
force-pushed
the
bunio_disallow_rialtomseaudio_in_webaudio
branch
2 times, most recently
from
21cbe42 to
acad87f
Compare
BunioFH
force-pushed
the
bunio_disallow_rialtomseaudio_in_webaudio
branch
from
acad87f to
d50c86f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this affects
AudioContext.decodeAudioDatausage when there is a discrepancy betweenrialtomseaudiosinkand software decoding plugins available on the platform. such a situation causesHTMLMediaElement::canPlayTypedeclare support for content type but it should be understood as playback and not decoding toPCM. in turn it makesautoplug-selectas used in AudioFileReaderGStreamer.cpp to pickrialtomseaudiosinkwhich is invalid as per case when:PCMcontent is used - get stuck in sample passing loop, it will be waiting to play which doesn't really happen in this scenario as samples were to be pulled and passed to another pipelinePCMcontent is used - crash as the samples pulled won't be available to be takenadding
rialtomseaudiosinkto disallowed plugins list in quirks corrects the situation and in case of missing browser side decoding plugin makes it simply fail. when they are present however they will be the only and right choice for decoding making it work as expected.d50c86f