-
Notifications
You must be signed in to change notification settings - Fork 5
Enhance CMSSlider component with improved accessibility features #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Added ARIA attributes to the CMSSlider and SlideItem components to improve accessibility for screen readers. - Updated the keyboard navigation logic to ensure a better user experience for keyboard users.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
cms-map/README.md
Outdated
|
|
||
| ## React + TypeScript + Vite | ||
|
|
||
| This template provides a minimal setup to get React working in Vite with HMR and some ESLint rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we tweak the README to align similar to the other examples in the repo (getting it up and running in Webflow, removing boilerplate README details)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
| @@ -0,0 +1 @@ | |||
| VITE_MAP_KEY=your_mapbox_api_key_here.example | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any disclaimers we need to make with this API key on client side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is public key safe to expose on client side. I'll add info folks need to setup the mapbox account
zplata
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Let's just make sure README is aligned with others but super excited to get this one in
…up instructions - Revised the README to provide a clearer overview of the CMS Map component, including its integration with Mapbox and Webflow CMS. - Added detailed setup instructions, component properties, and technical implementation notes. - Included a preview screenshot and highlighted key features for better user understanding.
Uh oh!
There was an error while loading. Please reload this page.