Configurable Spacing After ":" in JSON via "Customize JSON Output" addon #14733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavohri
commented
Apr 29, 2025
nijel
reviewed
Apr 29, 2025
Member
nijel
left a comment
nijel
left a comment
There was a problem hiding this comment.
Looks good. Can you please also update the documentation and add a changelog entry?
Contributor
Author
Sure! |
nijel
reviewed
May 5, 2025
docs/changes/contributors/5.11.rst
Outdated
| .. only:: not gettext | ||
|
|
||
| Michal Čihař, Gersona, Kartik Ohri, Mehdi El Oualy, Yash Kumar, nijel, Viktor Khokhryakov, AliceVisek, KasukabeDefenceForce | ||
| Michal Čihař, Gersona, Kartik Ohri, Mehdi El Oualy, Yash Kumar, nijel, Viktor Khokhryakov, AliceVisek, Abhinav Ohri |
Member
There was a problem hiding this comment.
This name is taken from Git commits.
Contributor
Author
There was a problem hiding this comment.
Apologies, reverted it.
AliceVisek
approved these changes
May 5, 2025
nijel
added a commit
to nijel/weblate
that referenced
this pull request
May 6, 2025
Noticed by @KasukabeDefenceForce in WeblateOrg#14733.
nijel
reviewed
May 6, 2025
Co-authored-by: AliceVisek <alice@weblate.org>
nijel
added a commit
that referenced
this pull request
May 6, 2025
Noticed by @KasukabeDefenceForce in #14733.
nijel
reviewed
May 6, 2025
nijel
reviewed
May 6, 2025
nijel
reviewed
May 6, 2025
weblate/addons/json.py
Outdated
| store.store.dump_args["sort_keys"] = bool(int(config.get("sort_keys", 0))) | ||
| use_compact_separators = bool(int(config.get("use_compact_separators", 0))) | ||
| store.store.dump_args["separators"] = ( | ||
| (",", ":") if use_compact_separators else (", ", ": ") |
Member
There was a problem hiding this comment.
As indent is always turned on, this should be:
Suggested change
| (",", ":") if use_compact_separators else (", ", ": ") | |
| (",", ":" if use_compact_separators else ": ") |
See https://docs.python.org/3/library/json.html#json.dump
The tests I've added in #14795 reveal this.
nijel
reviewed
May 6, 2025
weblate/addons/forms.py
Outdated
| class JSONCustomizeForm(BaseAddonForm): | ||
| sort_keys = forms.BooleanField(label=gettext_lazy("Sort JSON keys"), required=False) | ||
| use_compact_separators = forms.BooleanField( | ||
| label=gettext_lazy("Compact Mode"), |
Member
There was a problem hiding this comment.
I think it is better to be more verbose here:
Suggested change
| label=gettext_lazy("Compact Mode"), | |
| label=gettext_lazy("Avoid spaces after separators"), |
nijel
reviewed
May 6, 2025
docs/admin/addons.rst
Outdated
Comment on lines
890
to
892
| | ``use_compact_separators`` | Use compact separators in | ``true`` or ``false``| | ||
| | | JSON output (no space after | | | ||
| | | ``:`` and ``,``) | | |
Member
There was a problem hiding this comment.
Sync with ode changes:
Suggested change
| | ``use_compact_separators`` | Use compact separators in | ``true`` or ``false``| | |
| | | JSON output (no space after | | | |
| | | ``:`` and ``,``) | | | |
| | ``use_compact_separators`` | Avoid spaces after separators| | |
auto-merge was automatically disabled
May 7, 2025 17:12
Head branch was pushed to by a user without write access
Member
|
Merged, thanks for your contribution! |
nijel
added a commit
that referenced
this pull request
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a field to make compact mode configurable for json files translated by weblate.
Fixes #14126