feat: import comment api #14734
Merged
feat: import comment api #14734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the /api/units/{unit_id}/comments/ endpoint to accept user and timestamp for a comment
if the user making the request is a project admin. Return the comment id in the response as
it is useful in testing and can also be useful in future resolve/delete comment APIs.
nijel
requested changes
Apr 30, 2025
| comment=text, | ||
| userdetails={ | ||
| kwargs = { | ||
| "user": user, |
Member
There was a problem hiding this comment.
It is no longer set from request?
Contributor
Author
There was a problem hiding this comment.
It is set from the request but in in the views, I'll shift that logic to here.
Enhanced API response to include serialized comment details.
AliceVisek
approved these changes
May 5, 2025
nijel
reviewed
May 6, 2025
| # Is this source or target comment? | ||
| unit_scope = unit.source_unit if scope in {"global", "report"} else unit | ||
|
|
||
| user = request.user |
Member
There was a problem hiding this comment.
The user variable is also used later in the code, and keeping it None value causes crashes (as can be seen in the tests).
nijel
approved these changes
May 12, 2025
Member
|
Merged, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the /api/units/{unit_id}/comments/ endpoint to accept user and timestamp for a comment if the user making the request is a project admin. Return the comment id in the response as it is useful in testing and can also be useful in future resolve/delete comment APIs.
Fixes #14232.