-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(tbx): handle extended metadata in tbx format #14998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14998 +/- ##
=======================================
Coverage 91.15% 91.16%
=======================================
Files 626 626
Lines 65459 65513 +54
Branches 6751 6759 +8
=======================================
+ Hits 59672 59724 +52
Misses 4059 4059
- Partials 1728 1730 +2
🚀 New features to boost your workflow:
|
|
Indeed pushing that to translate-toolkit seems reasonable. For the various comments, it could be also implemented there, the |
|
translate/translate#5601. For comments, explanation does not seem to be a unit field in translate-tooklit. |
|
https://github.com/translate/translate/releases/tag/3.15.3 is out with the changes, you can now base on that after adjusting the minimal required version. |
Handle TermWeb extended metadata: 'definition', 'Translation needed', 'administrativeStatus' and 'Usage note' in accordance with WeblateOrg#12795. The `_get_notes_list` method is reimplemented in `TBXUnit` based on translate toolkit's `tbxunit.getnotes` to appropriately filter the extended metadata terms based on node tag and attributes.
|
Merged, thanks for your contribution! |
Handle TermWeb extended metadata: 'definition', 'Translation needed', 'administrativeStatus' and 'Usage note' in accordance with #12795. The
_get_notes_listmethod is reimplemented inTBXUnitbased on translate toolkit'stbxunit.getnotesto appropriately filter the extended metadata terms based on node tag and attributes.I was a bit perplexed by the reference files attached in the the issue. They were multilingual files and it took me a while to realize that weblate doesn't support importing multilingual files (only mono or bi). Further, the TBX format (at least some versions if not all) support multiple
terms insidetermEntrytag, in these cases Weblate only considers the firsttermtag. Please correct me if my understanding is wrong.The
administrativeStatusandTranslation neededseem general enough to upstream the support in Translate Toolkit. Thoughts?