-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(memory): add option to disable personal and project TM contribution #15011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Introduce `contribute_personal_tm` for user profiles and `contribute_project_tm` for components, to enable selective contribution to translation memory. If `contribute_personal_tm` is disabled, the user's translation memory is not updated. If `contribute_project_tm` is disabled for a component, the associated project's translation memory is not updated.
nijel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the shared instance memory also be not updated when the contribute_project_tm is disabled for a component?
Yes, it makes sense to make it as opt out from the translation memory.
On the other side, I think user setting should influence only the user translation memory (what your correctly did).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15011 +/- ##
=======================================
Coverage 91.15% 91.15%
=======================================
Files 626 628 +2
Lines 65444 65506 +62
Branches 6755 6752 -3
=======================================
+ Hits 59653 59713 +60
- Misses 4063 4065 +2
Partials 1728 1728
🚀 New features to boost your workflow:
|
|
Merged, thanks for your contribution! |
Introduce
contribute_personal_tmfor user profiles andcontribute_project_tmfor components, to enable selective contribution to translation memory. Ifcontribute_personal_tmis disabled, the user's translation memory is not updated. Ifcontribute_project_tmis disabled for a component, the associated project's translation memory is not updated.Question: Should the shared instance memory also be not updated when the
contribute_project_tmis disabled for a component?