Skip to content

Conversation

@amCap1712
Copy link
Contributor

Introduce contribute_personal_tm for user profiles and contribute_project_tm for components, to enable selective contribution to translation memory. If contribute_personal_tm is disabled, the user's translation memory is not updated. If contribute_project_tm is disabled for a component, the associated project's translation memory is not updated.

Question: Should the shared instance memory also be not updated when the contribute_project_tm is disabled for a component?

Introduce `contribute_personal_tm` for user profiles and `contribute_project_tm` for components,
to enable selective contribution to translation memory. If `contribute_personal_tm` is disabled,
the user's translation memory is not updated. If `contribute_project_tm` is disabled for a
component, the associated project's translation memory is not updated.
@amCap1712 amCap1712 requested a review from nijel as a code owner May 26, 2025 10:27
Copy link
Member

@nijel nijel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the shared instance memory also be not updated when the contribute_project_tm is disabled for a component?

Yes, it makes sense to make it as opt out from the translation memory.

On the other side, I think user setting should influence only the user translation memory (what your correctly did).

@nijel nijel added this to the 5.12 milestone May 26, 2025
@codecov
Copy link

codecov bot commented May 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.15%. Comparing base (c4a0a54) to head (66bfefa).
⚠️ Report is 3024 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #15011   +/-   ##
=======================================
  Coverage   91.15%   91.15%           
=======================================
  Files         626      628    +2     
  Lines       65444    65506   +62     
  Branches     6755     6752    -3     
=======================================
+ Hits        59653    59713   +60     
- Misses       4063     4065    +2     
  Partials     1728     1728           
Files with missing lines Coverage Δ
weblate/accounts/forms.py 89.27% <ø> (ø)
.../migrations/0017_profile_contribute_personal_tm.py 100.00% <100.00%> (ø)
weblate/accounts/models.py 86.77% <100.00%> (+0.03%) ⬆️
weblate/memory/tasks.py 100.00% <100.00%> (+5.17%) ⬆️
weblate/memory/tests.py 100.00% <100.00%> (ø)
weblate/trans/forms.py 89.94% <ø> (+0.10%) ⬆️
...migrations/0037_component_contribute_project_tm.py 100.00% <100.00%> (ø)
weblate/trans/models/component.py 81.55% <100.00%> (+0.05%) ⬆️

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amCap1712 amCap1712 requested a review from nijel June 10, 2025 13:48
@nijel nijel self-assigned this Jun 12, 2025
@nijel nijel merged commit 4ddc8a6 into WeblateOrg:main Jun 12, 2025
48 of 50 checks passed
@nijel
Copy link
Member

nijel commented Jun 12, 2025

Merged, thanks for your contribution!

@amCap1712 amCap1712 deleted the tmm-enrichment branch July 4, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translation Memory Management - provide option to switch off automatic TM enrichement

2 participants