Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Redis pub/sub communication between the base station and app components to replace named pipe communication, with fallback support to named pipes when Redis is unavailable.
- Introduces Redis pub/sub for real-time CAN message communication
- Implements fallback mechanism to named pipes when Redis connection fails
- Updates code formatting from single quotes to double quotes throughout
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pecan/app.py | Adds Redis client initialization and pub/sub listener with named pipe fallback |
| base-station/requirements.txt | Adds Redis and cantools dependencies |
| base-station/docker-compose.yml | Adds Redis service with persistent volume |
| base-station/base.py | Implements Redis pub/sub publishing with named pipe fallback |
| base-station/Dockerfile | Updates to install dependencies from requirements.txt |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
We will see if we can test this on Oct 9 Thursday. Sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will test on September 25, 2025. Merge after testing with the car.