Skip to content

Adding Pub/sub for communication between base and app#1

Merged
numcap merged 2 commits into
mainfrom
pub/sub
Oct 15, 2025
Merged

Adding Pub/sub for communication between base and app#1
numcap merged 2 commits into
mainfrom
pub/sub

Conversation

@haoruizhou
Copy link
Copy Markdown
Contributor

Will test on September 25, 2025. Merge after testing with the car.

@haoruizhou haoruizhou requested a review from Copilot September 25, 2025 03:48
@haoruizhou haoruizhou self-assigned this Sep 25, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Redis pub/sub communication between the base station and app components to replace named pipe communication, with fallback support to named pipes when Redis is unavailable.

  • Introduces Redis pub/sub for real-time CAN message communication
  • Implements fallback mechanism to named pipes when Redis connection fails
  • Updates code formatting from single quotes to double quotes throughout

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
pecan/app.py Adds Redis client initialization and pub/sub listener with named pipe fallback
base-station/requirements.txt Adds Redis and cantools dependencies
base-station/docker-compose.yml Adds Redis service with persistent volume
base-station/base.py Implements Redis pub/sub publishing with named pipe fallback
base-station/Dockerfile Updates to install dependencies from requirements.txt

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread pecan/app.py
Comment thread base-station/base.py
Comment thread base-station/base.py
Comment thread base-station/base.py
@haoruizhou
Copy link
Copy Markdown
Contributor Author

We will see if we can test this on Oct 9 Thursday. Sorry for the delay

@numcap numcap merged commit 57bbc3d into main Oct 15, 2025
@numcap numcap deleted the pub/sub branch October 15, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants