Conversation
pollaro
added a commit
that referenced
this pull request
Jul 11, 2024
[NET-193] - Integrate Winkler Method and Westfall-Young method into NLA (#38) * fixed network test result and NLA_GUI and NLAResult for new rankings * Exported mlapp files * fixing up result rank and network test result to add new rankings * Exported mlapp files --------- Co-authored-by: Github Action <action@github.com> [NET-193] Fix for ResultRank tests (#40) * fix for result rank tests * finally found all errors * another test fix [NET-193] Fix denominator calc (#41) fix error in denominator calculation [NET-196] Fix Cohen's D test not running (#43) fix cohensd [NET-197] Fix Winkler math (#45) fixed winkler error and westfall_young storage
pollaro
added a commit
that referenced
this pull request
Aug 30, 2024
* moved diagnostic plots to there own class * fixed up gui * [NET-193] - Integrate Winkler Method and Westfall-Young method into NLA (#38) * fixed network test result and NLA_GUI and NLAResult for new rankings * Exported mlapp files * fixing up result rank and network test result to add new rankings * Exported mlapp files --------- Co-authored-by: Github Action <action@github.com> * [NET-193] Fix for ResultRank tests (#40) * fix for result rank tests * finally found all errors * another test fix * [NET-193] Fix denominator calc (#41) fix error in denominator calculation * [NET-196] Fix Cohen's D test not running (#43) fix cohensd * [NET-197] Fix Winkler math (#45) fixed winkler error and westfall_young storage * removed diagnostic plots * changed size of some figures * start of large plot wrapper * trying to figure out where to go * add button object to input fields * doing better on drawing options * finally got buttons in correct spots * adding in the trimatrix options * trying to add colorbar choice * trying to get the colormap choice. this is a rough, but there's improvements still * able to get changes and sort them into the correct function to use * semicolon * fixing some errors found * getting matrix plot attached * data showing up in trimatrix * scaling and colorbar work correctly * fixed checkbox error * fix cohend test * fix winkler math * chord plotting seems to be working. no guarantees * starting to add convergence * convergence plot * finally figured out cohen's d issues * changes to background colors * adding title to single plot * starting to integrate single plot. * adding chord plotting and cohens d filter to networktestplot * trying to streamline chords * edge chord plotting with selector appears to function * Things are starting to work well, except that the options panel is too short * fixed options panel size and p-max threshold * [NET-214] Error plotting Chi-squared and Hypergeometric within network pair (#58) added check for tests without single sample * added in one plot and wired it up * changes to networktestresult to eliminate lots of code, result rank to fix issues * Exported mlapp files * fixes to diagnostic plots * Exported mlapp files * Exported mlapp files --------- Co-authored-by: Github Action <action@github.com>
pollaro
added a commit
that referenced
this pull request
Mar 25, 2025
* moved diagnostic plots to there own class * fixed up gui * [NET-193] - Integrate Winkler Method and Westfall-Young method into NLA (#38) * fixed network test result and NLA_GUI and NLAResult for new rankings * Exported mlapp files * fixing up result rank and network test result to add new rankings * Exported mlapp files --------- Co-authored-by: Github Action <action@github.com> * [NET-193] Fix for ResultRank tests (#40) * fix for result rank tests * finally found all errors * another test fix * [NET-193] Fix denominator calc (#41) fix error in denominator calculation * [NET-196] Fix Cohen's D test not running (#43) fix cohensd * [NET-197] Fix Winkler math (#45) fixed winkler error and westfall_young storage * removed diagnostic plots * changed size of some figures * start of large plot wrapper * trying to figure out where to go * add button object to input fields * doing better on drawing options * finally got buttons in correct spots * adding in the trimatrix options * trying to add colorbar choice * trying to get the colormap choice. this is a rough, but there's improvements still * able to get changes and sort them into the correct function to use * semicolon * fixing some errors found * getting matrix plot attached * data showing up in trimatrix * scaling and colorbar work correctly * fixed checkbox error * fix cohend test * fix winkler math * chord plotting seems to be working. no guarantees * starting to add convergence * convergence plot * finally figured out cohen's d issues * changes to background colors * adding title to single plot * starting to integrate single plot. * adding chord plotting and cohens d filter to networktestplot * trying to streamline chords * edge chord plotting with selector appears to function * Things are starting to work well, except that the options panel is too short * fixed options panel size and p-max threshold * [NET-214] Error plotting Chi-squared and Hypergeometric within network pair (#58) added check for tests without single sample * added in one plot and wired it up * changes to networktestresult to eliminate lots of code, result rank to fix issues * Exported mlapp files * fixes to diagnostic plots * Exported mlapp files * Exported mlapp files --------- Co-authored-by: Github Action <action@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The denominator on the winkler calculation was wrong. It needs to be only permutations.
Also, the westfall-young result was being saved in the wrong location