[NET-218] Remove sort from Eggebrecht ranking#67
Merged
pollaro merged 9 commits intodevelopmentfrom Oct 9, 2024
Merged
Conversation
…k pair (#58) added check for tests without single sample
make sprintf one line
removed sort in eggebrecht ranking
…ng method for p-value calc
pollaro
added a commit
that referenced
this pull request
Mar 25, 2025
* [NET-214] Error plotting Chi-squared and Hypergeometric within network pair (#58) added check for tests without single sample * [NET-216] Make `commitString.m` shell agnostic (#62) make sprintf one line * remove sorts from result rank * fixed an error in merging stats and probabilities. removed sort in eggebrecht ranking * result rank is a mess and I'm still not sure it's correct * rename directory...again * added ability for hypergeo to use p-value as a stat. also fixed summing method for p-value calc * added the 1 - to get the p-value using p-values of tests correct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To calculate a p-value, one can count the values of a statistic that are higher than the "observed."
There's two ways to do this:
The second value is what used to be done in legacy. But sorting is roughly O(n log n), which a find is O(log n). Doing the running sum is O(n). So, we gain a small speed up, which is really only noticeable when n starts approaching large numbers. 1000's or more.
There was also an issue where it doesn't appear the statistics were being combined correctly for single sample tests. Fixed