[NET-229] Both Benjamini corrections causing errors#80
Merged
pollaro merged 1 commit intodevelopmentfrom Nov 5, 2024
Merged
Conversation
pollaro
added a commit
that referenced
this pull request
Mar 25, 2025
added conditional for pmax is zero. clear out obj.title to fix repeating
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a couple of errors.
The first is that if p_value_max = 0, the colorbar tries to create a scale from [1 1 1]. This is a colormap consisting of white. Nothing else. This will error when trying to calculate the spread of top to bottom. The scale is easy 1 -> 1. That's a scale of length 0, so we'll get NaN for the min and max. That's the error. Put a conditional in to assign 0 to the max and min scale if this is the situation.
Second error is much the same. Normally we have something like
P < 0.05in the title. If there's no scale, that means there's no data, soP = 0Finally, in a related issue, NET-234, the title is appending itself instead of re-initializing. Just added a clear before the title is assigned.